From: Eric Dumazet <eric.dumazet@gmail.com>
To: Brendan McGrath <redmcg@redmandi.dyndns.org>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipv6: ip6mr: Recalc UDP checksum before forwarding
Date: Wed, 13 Dec 2017 09:52:44 -0800 [thread overview]
Message-ID: <1513187564.25033.65.camel@gmail.com> (raw)
In-Reply-To: <1513164048-21368-1-git-send-email-redmcg@redmandi.dyndns.org>
On Wed, 2017-12-13 at 22:20 +1100, Brendan McGrath wrote:
> Currently, when forwarding from a Virtual Interface to a Physical
> Interface, ip_summed is set to a value of CHECKSUM_UNNECESSARY and
> the UDP checksum has not been calculated.
>
This seems a bug then ?
CHECKSUM_UNNECESSARY means checksum has been validated.
Not that we want it being computed later in the stack.
If we force a checksum here, what guarantee do we have packet was not
corrupted before we do this ?
next prev parent reply other threads:[~2017-12-13 17:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 11:20 [PATCH] ipv6: ip6mr: Recalc UDP checksum before forwarding Brendan McGrath
2017-12-13 17:21 ` Marcelo Ricardo Leitner
2017-12-13 17:52 ` Eric Dumazet [this message]
2017-12-13 19:02 ` Brendan McGrath
2017-12-14 11:37 ` [PATCHv2] " Brendan McGrath
2017-12-15 18:27 ` David Miller
2017-12-16 12:19 ` Brendan McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513187564.25033.65.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=redmcg@redmandi.dyndns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).