From: Joe Perches <joe@perches.com>
To: Aniruddha Shastri <aniruddha.shastri@gmail.com>
Cc: "Ian Abbott" <abbotti@mev.co.uk>,
"H Hartley Sweeten" <hsweeten@visionengravers.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Saber Rezvani" <irsaber@gmail.com>,
"Matthew Giassa" <matthew@giassa.net>,
"Christopher Mårtensson" <cribalik@gmail.com>,
"Karthik Nayak" <karthik.188@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: comedi: ni_*: Fix style warnings.
Date: Wed, 13 Dec 2017 22:48:24 -0800 [thread overview]
Message-ID: <1513234104.27409.49.camel@perches.com> (raw)
In-Reply-To: <1513232885-60710-1-git-send-email-aniruddha.shastri@gmail.com>
On Thu, 2017-12-14 at 00:27 -0600, Aniruddha Shastri wrote:
> Three of these warnings are now line-too-long warnings. I think these
> warnings are preferable to the ones listed below. The longest line
> is only 87 chars wide, which is reasonable.
[]
> diff --git a/drivers/staging/comedi/drivers/ni_670x.c b/drivers/staging/comedi/drivers/ni_670x.c
[]
> @@ -209,7 +209,7 @@ static int ni_670x_auto_attach(struct comedi_device *dev,
> const struct comedi_lrange **range_table_list;
>
> range_table_list = kmalloc_array(32,
> - sizeof(struct comedi_lrange *),
> + sizeof(const struct comedi_lrange *),
Adding const to a sizeof is unnecessary
next prev parent reply other threads:[~2017-12-14 6:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 10:01 [PATCH] staging: comedi: ni_* Aniruddha Shastri
2017-12-13 10:50 ` Greg Kroah-Hartman
2017-12-13 11:46 ` Aniruddha Shastri
2017-12-13 12:07 ` Greg Kroah-Hartman
2017-12-14 6:27 ` [PATCH v2] staging: comedi: ni_*: Fix style warnings Aniruddha Shastri
2017-12-14 6:48 ` Joe Perches [this message]
2017-12-14 7:31 ` [PATCH v3] " Aniruddha Shastri
2017-12-19 13:59 ` Greg Kroah-Hartman
2017-12-14 7:48 ` [PATCH] staging: comedi: ni_* Aniruddha Shastri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513234104.27409.49.camel@perches.com \
--to=joe@perches.com \
--cc=abbotti@mev.co.uk \
--cc=aniruddha.shastri@gmail.com \
--cc=cribalik@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=irsaber@gmail.com \
--cc=karthik.188@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@giassa.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox