From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755072AbdLOLKQ (ORCPT ); Fri, 15 Dec 2017 06:10:16 -0500 Received: from mga07.intel.com ([134.134.136.100]:57315 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753218AbdLOLKM (ORCPT ); Fri, 15 Dec 2017 06:10:12 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,404,1508828400"; d="scan'208";a="18489529" Message-ID: <1513336205.7000.106.camel@linux.intel.com> Subject: Re: [PATCH 1/9] ASoC: Intel: Fix Kconfig with top-level selector From: Andy Shevchenko To: Pierre-Louis Bossart , alsa-devel@vger.kernel.org Cc: tiwai@suse.de, broonie@kernel.org, torvalds@linux-foundation.org, vinod.koul@intel.com, liam.r.girdwood@linux.intel.com, arnd@arndb.de, linux-kernel@vger.kernel.org Date: Fri, 15 Dec 2017 13:10:05 +0200 In-Reply-To: <20171215004451.30800-2-pierre-louis.bossart@linux.intel.com> References: <20171215004451.30800-1-pierre-louis.bossart@linux.intel.com> <20171215004451.30800-2-pierre-louis.bossart@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-12-14 at 18:44 -0600, Pierre-Louis Bossart wrote: > Follow network example suggested by Linus, move Intel definitions > in if/endif block and clarify in help text which options distro > configurations should enable - everything except legacy Baytrail stuff > and > NOCODEC (test only) > > To avoid user confusion, machine drivers are handled with a submenu > made > dependent on this top-level selector. > > There should be no functionality change - except that sound > capabilities > are restored when using older configs without any user selection. > > Note that the SND_SOC_ACPI_INTEL_MATCH config is not filtered out by > the top-level selector since it will also be selected with the > upcoming > SOF drivers. Likewise the machine drivers are filtered by a top-level > selector which will allow for selection/reuse of the same machine > driver > with existing SST or SOF-based platform drivers. > > (simplification with submenu for machine drivers by Vinod Koul) My comments below. > +if SND_SOC_INTEL_SST_TOPLEVEL ... > + > +endif ## SND_SOC_INTEL_SST_TOPLEVEL > +# configs common to SST and SOF to use matching tables > + > +config SND_SOC_ACPI_INTEL_MATCH > + tristate > + depends on X86 && ACPI > + select SND_SOC_ACPI > + # this option controls the compilation of ACPI matching > tables and this -> This ? > + # helpers and is not meant to be selected by the user. It is > not > + # filtered out on purpose by the top-level selector since it > will > + # be selected by SST or SOF platform driver options > if SND_SOC_INTEL_MACH > +if SND_SOC_INTEL_HASWELL ... > +endif > + > +if SND_SOC_INTEL_BAYTRAIL > > config SND_SOC_INTEL_BYT_MAX98090_MACH > tristate "ASoC Audio driver for Intel Baytrail with MAX98090 > codec" > depends on X86_INTEL_LPSS && I2C > - depends on SND_SST_IPC_ACPI = n > - depends on SND_SOC_INTEL_BAYTRAIL > select SND_SOC_MAX98090 > help > This adds audio driver for Intel Baytrail platform based > boards > - with the MAX98090 audio codec. > + with the MAX98090 audio codec. This driver is deprecated, > use > + SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH instead for better > + functionality. Looking to somehow established practice (few other Kconfigs in the kernel) I would suggest to add " (DEPRECATED)" to the tristate help string. > +endif > + > +if SND_SST_ATOM_HIFI2_PLATFORM ... > +endif > + > +if SND_SOC_INTEL_SKYLAKE ... > If unsure select "N". > - I would rather not remove this empty line. > endif > + > +endif ## SND_SOC_INTEL_MACH -- Andy Shevchenko Intel Finland Oy