From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757085AbdLPUkp (ORCPT ); Sat, 16 Dec 2017 15:40:45 -0500 Received: from smtprelay0251.hostedemail.com ([216.40.44.251]:52621 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751268AbdLPUkn (ORCPT ); Sat, 16 Dec 2017 15:40:43 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:2899:3138:3139:3140:3141:3142:3350:3622:3865:3867:3870:3872:3873:4321:5007:6691:10004:10400:10848:11232:11658:11914:12663:12740:12760:12895:13069:13095:13255:13311:13357:13439:14659:21080:21212:21324:21433:21627:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: alarm03_7a6f8d0ac8c3f X-Filterd-Recvd-Size: 1454 Message-ID: <1513456839.4647.53.camel@perches.com> Subject: Re: tps65090-charger: Delete an error message for a failed memory allocation in two functions From: Joe Perches To: SF Markus Elfring , linux-pm@vger.kernel.org Cc: Sebastian Reichel , LKML , kernel-janitors@vger.kernel.org Date: Sat, 16 Dec 2017 12:40:39 -0800 In-Reply-To: <4beb0d2e-adf6-5eeb-43c7-7829d54c6656@users.sourceforge.net> References: <1513450432.4647.47.camel@perches.com> <4beb0d2e-adf6-5eeb-43c7-7829d54c6656@users.sourceforge.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-12-16 at 21:30 +0100, SF Markus Elfring wrote: > > > Omit an extra message for a memory allocation failure in these functions. > > > > Because??? > > > > Fix your commit message. > > > > Say _WHY_ should this be applied. > > I am still waiting for possibilities to improve also the corresponding > reference documentation somehow as you know it already. Don't submit any more patches until you do have this resolved.