public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Martin Homuth <martin@martinhomuth.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] staging: rtl8712: fix several checkpatch style issues
Date: Mon, 18 Dec 2017 14:28:18 -0800	[thread overview]
Message-ID: <1513636098.1234.11.camel@perches.com> (raw)
In-Reply-To: <b96f4056-a379-7f34-aa46-128d208f9d63@martinhomuth.de>

On Mon, 2017-12-18 at 23:17 +0100, Martin Homuth wrote:
> On 12/18/2017 10:21 PM, Joe Perches wrote:
> > On Mon, 2017-12-18 at 21:36 +0100, Martin Homuth wrote:
> > > This patch series fixes some coding style issues reported by checkpatch.pl.
> > > 
> > > It is based on next-20171218
> > > 
> > > Martin Homuth (5):
> > >   staging: rtl8712: style fix over 80 characters warnings
> > >   staging: rtl8712: style fix multiple line dereferences
> > >   staging: rtl8712: style fix indentation
> > >   staging: rtl8712: style fix unneeded else
> > >   staging: rtl8712: style fix returned error code
> > > 
> > >  drivers/staging/rtl8712/ieee80211.c           |  6 ++-
> > >  drivers/staging/rtl8712/os_intfs.c            |  5 +-
> > >  drivers/staging/rtl8712/rtl8712_cmd.c         | 18 ++++---
> > >  drivers/staging/rtl8712/rtl8712_recv.c        |  8 +--
> > >  drivers/staging/rtl8712/rtl8712_xmit.c        |  3 +-
> > >  drivers/staging/rtl8712/rtl871x_cmd.c         | 36 +++++++-------
> > >  drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 72
> > > ++++++++++++++-------------
> > 
> > This line wrapping is generally an indication that your email
> > client (thunderbird 52.5.0) is wrapping all patches.
> > 
> > If you can, use git send-email instead
> > 
> > 
> 
> Thank you very much, I wasn't aware of this problem and finally set up
> send-email appropriately. Should I resend the series right away or wait
> for additional comments?

I never looked at the patches.
The subjects look innocuous enough though.

I'd just resend as V2 after first resending only to
yourself to make sure the patches apply properly.

      reply	other threads:[~2017-12-18 22:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <c673a9e2-494d-c2f0-a0bd-3422ec76231d@martinhomuth.de>
2017-12-18 20:36 ` [PATCH 0/5] staging: rtl8712: fix several checkpatch style issues Martin Homuth
2017-12-18 21:21   ` Joe Perches
2017-12-18 22:17     ` Martin Homuth
2017-12-18 22:28       ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513636098.1234.11.camel@perches.com \
    --to=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin@martinhomuth.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox