From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762071AbdLSKtj (ORCPT ); Tue, 19 Dec 2017 05:49:39 -0500 Received: from mga07.intel.com ([134.134.136.100]:28544 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759579AbdLSKtf (ORCPT ); Tue, 19 Dec 2017 05:49:35 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,426,1508828400"; d="scan'208";a="13548751" Message-ID: <1513680571.7000.169.camel@linux.intel.com> Subject: Re: [PATCH 2/9] ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies From: Andy Shevchenko To: Pierre-Louis Bossart , alsa-devel@alsa-devel.org Cc: tiwai@suse.de, broonie@kernel.org, torvalds@linux-foundation.org, vinod.koul@intel.com, liam.r.girdwood@linux.intel.com, arnd@arndb.de, linux-kernel@vger.kernel.org Date: Tue, 19 Dec 2017 12:49:31 +0200 In-Reply-To: <5d02951a-63d3-eb33-142e-46f16612626b@linux.intel.com> References: <20171215004451.30800-1-pierre-louis.bossart@linux.intel.com> <20171215004451.30800-3-pierre-louis.bossart@linux.intel.com> <1513335523.7000.95.camel@linux.intel.com> <5d02951a-63d3-eb33-142e-46f16612626b@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-12-15 at 06:34 -0600, Pierre-Louis Bossart wrote: > On 12/15/17 4:58 AM, Andy Shevchenko wrote: > > On Thu, 2017-12-14 at 18:44 -0600, Pierre-Louis Bossart wrote: > > > PCI/ACPI selections should not happen in Kconfig for machine > > > drivers, > > > move to SOC selections. > > > > > > Add distinction between PCI and ACPI HiFi2 platforms and help > > > text. > > > > > > There should be no functionality change. > > > > > > The PCI-based platforms may be removed at some point since > > > Medfield > > > is not really supported by anyone, and with Edison now defunct > > > support > > > for > > > Merrifield/Edison is to be determined. > > > > > > - depends on SND_DMA_SGBUF > > > + depends on SND_DMA_SGBUF && ACPI > > > depends on DMADEVICES > > > > Perhaps > > > > depends on DMADEVICES && ACPI > > > > to be in align with below? > > > > > config SND_SOC_INTEL_BAYTRAIL > > > tristate "Intel ASoC SST driver for Baytrail (legacy)" > > > - depends on DMADEVICES > > > + depends on DMADEVICES && ACPI > > I must admit I don't know why it's different, I just cleaned-up what > I > could. What I'm talking about is to use same pattern, so, in the first case depends on SND_DMA_SGBUF depends on DMADEVICES && ACPI The question WRT SGBUF is indeed another one to Liam or whoever knows better. > Maybe Liam can comment since I believe he contributed to both > Haswell and the initial Baytrail driver? -- Andy Shevchenko Intel Finland Oy