The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Crt Mori <cmo@melexis.com>, Jonathan Cameron <jic23@kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Kees Cook <keescook@chromium.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Ian Abbott <abbotti@mev.co.uk>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Niklas Soderlund <niklas.soderlund+renesas@ragnatech.se>,
	Thomas Gleixner <tglx@linutronix.de>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH v7 1/3] lib: Add strongly typed 64bit int_sqrt
Date: Tue, 19 Dec 2017 08:14:19 -0800	[thread overview]
Message-ID: <1513700059.1234.42.camel@perches.com> (raw)
In-Reply-To: <20171219161245.cbjmod7ak5scio7d@hirez.programming.kicks-ass.net>

On Tue, 2017-12-19 at 17:12 +0100, Peter Zijlstra wrote:
> On Tue, Dec 19, 2017 at 08:09:53AM -0800, Joe Perches wrote:
> > 
> > I suspect you need to define this as:
> > 
> > #define int_sqrt64(x) ((u32)int_sqrt(x))
> 
> What's wrong with using C ?

Duh.  Nothing at all.

> static inline u32 int_sqrt64(u64 x)
> {
> 	return int_sqrt(x);
> }

  reply	other threads:[~2017-12-19 16:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-19 15:59 [PATCH v7 1/3] lib: Add strongly typed 64bit int_sqrt Crt Mori
2017-12-19 16:09 ` Joe Perches
2017-12-19 16:12   ` Peter Zijlstra
2017-12-19 16:14     ` Joe Perches [this message]
2017-12-20  9:35       ` Crt Mori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513700059.1234.42.camel@perches.com \
    --to=joe@perches.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=abbotti@mev.co.uk \
    --cc=akpm@linux-foundation.org \
    --cc=cmo@melexis.com \
    --cc=jic23@kernel.org \
    --cc=keescook@chromium.org \
    --cc=krzk@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=peterz@infradead.org \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox