Re: [PATCH net-next v4 0/6] net: tcp: sctp: dccp: Replace jprobe usage with trace events

Masami Hiramatsu
2017-12-21T14:27:38Z

On Wed, 20 Dec 2017 22:12:38 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 21 Dec 2017 11:36:57 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > On Wed, 20 Dec 2017 14:24:24 -0500 (EST)
> > David Miller <davem@davemloft.net> wrote:
> >
> > > From: David Miller <davem@davemloft.net>
> > > Date: Wed, 20 Dec 2017 14:20:40 -0500 (EST)
> > >
> > > > From: Masami Hiramatsu <mhiramat@kernel.org>
> > > > Date: Wed, 20 Dec 2017 13:14:11 +0900
> > > >
> > > >> This series is v4 of the replacement of jprobe usage with trace
> > > >> events. This version is rebased on net-next, fixes a build warning
> > > >> and moves a temporal variable definition in a block.
> > > >>
> > > >> Previous version is here;
> > > >> https://lkml.org/lkml/2017/12/19/153
> > > >>
> > > >> Changes from v3:
> > > >> All: Rebased on net-next
> > > >> [3/6]: fixes a build warning for i386 by casting pointer unsigned
> > > >> long instead of __u64, and moves a temporal variable
> > > >> definition in a block.
> > > >
> > > > Looks good, series applied to net-next, thanks.
> > >
> > > Actually, this doesn't even compile, so I've reverted:
> > >
> > > [davem@dhcp-10-15-49-227 net-next]$ make -s -j16
> > > In file included from net/dccp/trace.h:105:0,
> > > from net/dccp/proto.c:42:
> > > ./include/trace/define_trace.h:89:42: fatal error: ./trace.h: No such file or directory
> > > #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> > > ^
> > > compilation terminated.
> >
> > Hi David,
> >
> > Could you share your .config file? I would like to reproduce it.
> > When I tried with attached kconfig, I could not reproduce this issue,
> > and could run it.
> >
>
> Hi Masami,
>
> Are you sure you committed everything in this change set? I don't see a
> modification of the Makefile to get the trace.h file you created.
> Shouldn't there be something like:
>
> CFLAGS_proto.o := -I$(src)
>
> in the Makefile?

You're correct. I could reproduce it with kallmodconfig.
And when I add below diff, it is resolved.
If I built with O= option, it didn't happen.

diff --git a/net/dccp/Makefile b/net/dccp/Makefile
index 9d0383d2f277..8d4a8e901ae0 100644
--- a/net/dccp/Makefile
+++ b/net/dccp/Makefile
@@ -25,3 +25,5 @@ obj-$(CONFIG_INET_DCCP_DIAG) += dccp_diag.o
dccp-$(CONFIG_SYSCTL) += sysctl.o

dccp_diag-y := diag.o
+
+CFLAGS_proto.o := -I$(src)

I'll update [5/6].

Thank you,

--
Masami Hiramatsu <mhiramat@kernel.org>