From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] scripts: Add device_attr_<rw|ro|wr>.pl scripts to convert DEVICE_ATTR uses
Date: Sat, 23 Dec 2017 06:24:27 -0800 [thread overview]
Message-ID: <1514039067.4599.21.camel@perches.com> (raw)
In-Reply-To: <20171223141929.GA6228@kroah.com>
On Sat, 2017-12-23 at 15:19 +0100, Greg Kroah-Hartman wrote:
> On Fri, Dec 22, 2017 at 12:02:47PM -0800, Joe Perches wrote:
> > There are many uses of the DEVICE_ATTR(var, perms, show, store)
> > declaration macro that could use one of the convenience macros
> > DEVICE_ATTR_RW, DEVICE_ATTR_RO, or DEVICE_ATTR_WO.
> >
> > These scripts automate those conversions.
[]
> We should just fix up all in-kernel users, no need to put the scripts in
> the kernel source tree, right?
There's really no need for these scripts in the kernel-tree
just as there's no real need for any coccinelle script once
any conversion is fully done.
Keeping the scripts around can help find more opportunities
for conversion as new code is added.
next prev parent reply other threads:[~2017-12-23 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 20:02 [PATCH] scripts: Add device_attr_<rw|ro|wr>.pl scripts to convert DEVICE_ATTR uses Joe Perches
2017-12-23 14:19 ` Greg Kroah-Hartman
2017-12-23 14:24 ` Joe Perches [this message]
2018-01-02 15:34 ` Joe Perches
2018-01-02 15:47 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1514039067.4599.21.camel@perches.com \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox