From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756698AbdLWOYc (ORCPT ); Sat, 23 Dec 2017 09:24:32 -0500 Received: from smtprelay0176.hostedemail.com ([216.40.44.176]:60498 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750841AbdLWOYb (ORCPT ); Sat, 23 Dec 2017 09:24:31 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3874:4031:4321:5007:10004:10400:10848:11026:11232:11473:11658:11914:12114:12740:12760:12895:13069:13161:13229:13255:13311:13357:13439:14659:14721:21080:21324:21433:21611:21627:30012:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: wind42_a2851813f21d X-Filterd-Recvd-Size: 1585 Message-ID: <1514039067.4599.21.camel@perches.com> Subject: Re: [PATCH] scripts: Add device_attr_.pl scripts to convert DEVICE_ATTR uses From: Joe Perches To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Julia Lawall Date: Sat, 23 Dec 2017 06:24:27 -0800 In-Reply-To: <20171223141929.GA6228@kroah.com> References: <863ff80559b868614cd965b431b07a99ca52509a.1513972839.git.joe@perches.com> <20171223141929.GA6228@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-12-23 at 15:19 +0100, Greg Kroah-Hartman wrote: > On Fri, Dec 22, 2017 at 12:02:47PM -0800, Joe Perches wrote: > > There are many uses of the DEVICE_ATTR(var, perms, show, store) > > declaration macro that could use one of the convenience macros > > DEVICE_ATTR_RW, DEVICE_ATTR_RO, or DEVICE_ATTR_WO. > > > > These scripts automate those conversions. [] > We should just fix up all in-kernel users, no need to put the scripts in > the kernel source tree, right? There's really no need for these scripts in the kernel-tree just as there's no real need for any coccinelle script once any conversion is fully done. Keeping the scripts around can help find more opportunities for conversion as new code is added.