From: Al Cooper <alcooperx@gmail.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Al Cooper <al.cooper@broadcom.com>,
Al Cooper <alcooperx@gmail.com>,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: [PATCH 3/4] phy: usb: phy-brcm-usb-init: Power down USB 3.0 PHY when XHCI disabled
Date: Wed, 27 Dec 2017 14:28:50 -0500 [thread overview]
Message-ID: <1514402931-14408-4-git-send-email-alcooperx@gmail.com> (raw)
In-Reply-To: <1514402931-14408-1-git-send-email-alcooperx@gmail.com>
From: Al Cooper <al.cooper@broadcom.com>
Set PHY3_IDDQ_OVERRIDE in the xhci uninit routine. This will save
additional power when the XHCI driver is not enabled.
Fixes: 49859e55e364 ("phy: usb: phy-brcm-usb: Add Broadcom STB USB phy driver")
Signed-off-by: Al Cooper <alcooperx@gmail.com>
---
drivers/phy/broadcom/phy-brcm-usb-init.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/phy/broadcom/phy-brcm-usb-init.c b/drivers/phy/broadcom/phy-brcm-usb-init.c
index 69ea479..6672adcc 100644
--- a/drivers/phy/broadcom/phy-brcm-usb-init.c
+++ b/drivers/phy/broadcom/phy-brcm-usb-init.c
@@ -73,6 +73,7 @@
#define USB_CTRL_USB30_CTL1_USB3_IPP_MASK 0x20000000 /* option */
#define USB_CTRL_USB30_PCTL 0x70
#define USB_CTRL_USB30_PCTL_PHY3_SOFT_RESETB_MASK 0x00000002
+#define USB_CTRL_USB30_PCTL_PHY3_IDDQ_OVERRIDE_MASK 0x00008000
#define USB_CTRL_USB30_PCTL_PHY3_SOFT_RESETB_P1_MASK 0x00020000
#define USB_CTRL_USB_DEVICE_CTL1 0x90
#define USB_CTRL_USB_DEVICE_CTL1_PORT_MODE_MASK 0x00000003 /* option */
@@ -998,6 +999,7 @@ void brcm_usb_uninit_eohci(struct brcm_usb_init_params *params)
void brcm_usb_uninit_xhci(struct brcm_usb_init_params *params)
{
brcmusb_xhci_soft_reset(params, 1);
+ USB_CTRL_SET(params->ctrl_regs, USB30_PCTL, PHY3_IDDQ_OVERRIDE);
}
void brcm_usb_set_family_map(struct brcm_usb_init_params *params)
--
1.9.0.138.g2de3478
next prev parent reply other threads:[~2017-12-27 19:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-27 19:28 [PATCH 0/4] Bug fixes for the Broadcom STB USB phy driver Al Cooper
2017-12-27 19:28 ` [PATCH 1/4] phy: usb: phy-brcm-usb: Fix two DT properties to match bindings doc Al Cooper
2017-12-28 1:24 ` Florian Fainelli
2017-12-27 19:28 ` [PATCH 2/4] phy: usb: phy-brcm-usb-init: Some Low Speed keyboards fail on 7271 Al Cooper
2017-12-28 1:24 ` Florian Fainelli
2017-12-27 19:28 ` Al Cooper [this message]
2017-12-28 1:24 ` [PATCH 3/4] phy: usb: phy-brcm-usb-init: Power down USB 3.0 PHY when XHCI disabled Florian Fainelli
2017-12-27 19:28 ` [PATCH 4/4] phy: usb: phy-brcm-usb-init: DRD mode can cause crash on startup Al Cooper
2017-12-28 1:25 ` Florian Fainelli
2017-12-28 11:13 ` [PATCH 0/4] Bug fixes for the Broadcom STB USB phy driver Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1514402931-14408-4-git-send-email-alcooperx@gmail.com \
--to=alcooperx@gmail.com \
--cc=al.cooper@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox