public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: William Breathitt Gray <vilhelm.gray@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2] gpio: winbond: add driver
Date: Thu, 28 Dec 2017 17:18:30 +0200	[thread overview]
Message-ID: <1514474310.7000.420.camel@linux.intel.com> (raw)
In-Reply-To: <309acd17-5244-da8c-a28e-dace15ada4fb@maciej.szmigiero.name>

On Fri, 2017-12-22 at 19:58 +0100, Maciej S. Szmigiero wrote:
> This commit adds GPIO driver for Winbond Super I/Os.

Linus, since you asked me to review this, I can conclude that it is a
bit far from readiness. Couple of more iterations needed.

Please, also answer to a comment in review in regard to gpio_valid_mask
use.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

      parent reply	other threads:[~2017-12-28 15:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-22 18:58 [PATCH v2] gpio: winbond: add driver Maciej S. Szmigiero
2017-12-24 22:42 ` William Breathitt Gray
2017-12-25  0:00   ` Maciej S. Szmigiero
2017-12-25 14:48     ` Maciej S. Szmigiero
2017-12-27  0:24       ` William Breathitt Gray
2017-12-27 11:16         ` Linus Walleij
2017-12-28  4:33           ` William Breathitt Gray
2017-12-28 12:52             ` Linus Walleij
2017-12-27 18:42         ` Maciej S. Szmigiero
2017-12-28  4:58           ` William Breathitt Gray
2017-12-28 22:45             ` Maciej S. Szmigiero
2017-12-28 15:12 ` Andy Shevchenko
2017-12-28 23:44   ` Maciej S. Szmigiero
2017-12-29 10:27     ` Andy Shevchenko
2017-12-29 16:09       ` William Breathitt Gray
2017-12-30 21:02         ` Maciej S. Szmigiero
2017-12-30 21:02       ` Maciej S. Szmigiero
2017-12-28 15:18 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1514474310.7000.420.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    --cc=vilhelm.gray@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox