linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Himanshu Jha <himanshujha199640@gmail.com>
To: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, aacraid@adaptec.com
Cc: anil.gurumurthy@qlogic.com, sudarsana.kalluru@qlogic.com,
	QLogic-Storage-Upstream@qlogic.com, satishkh@cisco.com,
	sebaddel@cisco.com, kartilak@cisco.com,
	QLogic-Storage-Upstream@cavium.com, qla2xxx-upstream@qlogic.com,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Himanshu Jha <himanshujha199640@gmail.com>
Subject: [PATCH 0/9] scsi: Use zeroing allocators than allocator/memset
Date: Sat, 30 Dec 2017 20:58:23 +0530	[thread overview]
Message-ID: <1514647712-6332-1-git-send-email-himanshujha199640@gmail.com> (raw)

There are many instances where a region of memory is allocated using
allocator functions and immediately the region of memory is zeroed using
memset function.

We already have zeroing memory allocator function for that purpose and
replacing the currently used allocator functions with zeroing allocators
will make code cleaner, easier to read, and also reduce the code size.

For eg:

Before:
himanshu@himanshu-Vostro-3559:~/linux-next$ size drivers/scsi/bnx2fc/bnx2fc_hwi.o
   text    data     bss     dec     hex filename
  40783    5940      64   46787    b6c3 drivers/scsi/bnx2fc/bnx2fc_hwi.o

After: 
himanshu@himanshu-Vostro-3559:~/linux-next$ size drivers/scsi/bnx2fc/bnx2fc_hwi.o
   text    data     bss     dec     hex filename
  40619    5940      64   46623    b61f drivers/scsi/bnx2fc/bnx2fc_hwi.o

Also, all these patches have been tested using 0-day test service with
zero build failures.

Done using Coccinelle.
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
Link: https://lkml.org/lkml/2017/12/26/205

Himanshu Jha (9):
  scsi: qla4xxx: Use zeroing allocator rather than allocator/memset
  scsi: qla2xxx: Use zeroing allocator rather than allocator/memset
  scsi: qedi: Use zeroing allocator instead of allocator/memset
  scsi: mvsas: Use zeroing allocator rather than allocator/memset
  scsi: fnic: Use zeroing allocator rather than allocator/memset
  scsi: dpt_i2o: Use zeroing allocator rather than allocator/memset
  scsi: bnx2fc: Use zeroing allocator rather than allocator/memset
  scsi: bfa: Use zeroing allocator rather than allocator/memset
  scsi: bnx2i: Use zeroing allocator rather than allocator/memset

 drivers/scsi/bfa/bfad.c            |  3 +-
 drivers/scsi/bfa/bfad_debugfs.c    |  8 ++---
 drivers/scsi/bnx2fc/bnx2fc_hwi.c   | 60 ++++++++++++++++----------------------
 drivers/scsi/bnx2fc/bnx2fc_tgt.c   | 51 ++++++++++++++------------------
 drivers/scsi/bnx2i/bnx2i_hwi.c     | 14 ++++-----
 drivers/scsi/dpt_i2o.c             | 19 +++++-------
 drivers/scsi/fnic/fnic_debugfs.c   | 10 ++-----
 drivers/scsi/fnic/fnic_trace.c     |  9 ++----
 drivers/scsi/mvsas/mv_init.c       | 27 +++++++----------
 drivers/scsi/qedi/qedi_main.c      | 42 ++++++++++----------------
 drivers/scsi/qla2xxx/qla_attr.c    |  5 ++--
 drivers/scsi/qla2xxx/qla_bsg.c     |  9 ++----
 drivers/scsi/qla2xxx/tcm_qla2xxx.c |  5 +---
 drivers/scsi/qla4xxx/ql4_init.c    |  5 ++--
 drivers/scsi/qla4xxx/ql4_mbx.c     | 21 ++++++-------
 drivers/scsi/qla4xxx/ql4_nx.c      |  5 ++--
 drivers/scsi/qla4xxx/ql4_os.c      | 12 ++++----
 17 files changed, 118 insertions(+), 187 deletions(-)

-- 
2.7.4

             reply	other threads:[~2017-12-30 15:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-30 15:28 Himanshu Jha [this message]
2017-12-30 15:28 ` [PATCH 1/9] scsi: qla4xxx: Use zeroing allocator rather than allocator/memset Himanshu Jha
2018-01-02  4:39   ` Rangankar, Manish
2018-01-04  6:08   ` Martin K. Petersen
2017-12-30 15:28 ` [PATCH 2/9] scsi: qla2xxx: " Himanshu Jha
2018-01-02 17:01   ` Madhani, Himanshu
2018-01-04  6:09   ` Martin K. Petersen
2017-12-30 15:28 ` [PATCH 3/9] scsi: qedi: Use zeroing allocator instead of allocator/memset Himanshu Jha
2018-01-02  4:40   ` Rangankar, Manish
2018-01-04  6:17   ` Martin K. Petersen
2017-12-30 15:28 ` [PATCH 4/9] scsi: mvsas: Use zeroing allocator rather than allocator/memset Himanshu Jha
2017-12-30 15:28 ` [PATCH 5/9] scsi: fnic: " Himanshu Jha
2017-12-30 15:28 ` [PATCH 6/9] scsi: dpt_i2o: " Himanshu Jha
2017-12-30 15:28 ` [PATCH 7/9] scsi: bnx2fc: " Himanshu Jha
2018-01-02 21:14   ` Chad Dupuis
2018-01-04  6:17   ` Martin K. Petersen
2018-01-04  7:38     ` Himanshu Jha
2018-01-09  3:35       ` Martin K. Petersen
2017-12-30 15:28 ` [PATCH 8/9] scsi: bfa: " Himanshu Jha
2018-01-02  5:40   ` Gurumurthy, Anil
2018-01-04  6:13   ` Martin K. Petersen
2017-12-30 15:28 ` [PATCH 9/9] scsi: bnx2i: " Himanshu Jha
2018-01-02  4:42   ` Rangankar, Manish
2018-01-04  6:13   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1514647712-6332-1-git-send-email-himanshujha199640@gmail.com \
    --to=himanshujha199640@gmail.com \
    --cc=QLogic-Storage-Upstream@cavium.com \
    --cc=QLogic-Storage-Upstream@qlogic.com \
    --cc=aacraid@adaptec.com \
    --cc=anil.gurumurthy@qlogic.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=kartilak@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=qla2xxx-upstream@qlogic.com \
    --cc=satishkh@cisco.com \
    --cc=sebaddel@cisco.com \
    --cc=sudarsana.kalluru@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).