linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Himanshu Jha <himanshujha199640@gmail.com>
To: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, aacraid@adaptec.com
Cc: anil.gurumurthy@qlogic.com, sudarsana.kalluru@qlogic.com,
	QLogic-Storage-Upstream@qlogic.com, satishkh@cisco.com,
	sebaddel@cisco.com, kartilak@cisco.com,
	QLogic-Storage-Upstream@cavium.com, qla2xxx-upstream@qlogic.com,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Himanshu Jha <himanshujha199640@gmail.com>
Subject: [PATCH 9/9] scsi: bnx2i: Use zeroing allocator rather than allocator/memset
Date: Sat, 30 Dec 2017 20:58:32 +0530	[thread overview]
Message-ID: <1514647712-6332-10-git-send-email-himanshujha199640@gmail.com> (raw)
In-Reply-To: <1514647712-6332-1-git-send-email-himanshujha199640@gmail.com>

Use dma_zalloc_coherent instead of dma_alloc_coherent followed by
memset 0.

Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci

Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
 drivers/scsi/bnx2i/bnx2i_hwi.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c b/drivers/scsi/bnx2i/bnx2i_hwi.c
index 9e3bf53..c6a0bd6 100644
--- a/drivers/scsi/bnx2i/bnx2i_hwi.c
+++ b/drivers/scsi/bnx2i/bnx2i_hwi.c
@@ -1069,16 +1069,15 @@ int bnx2i_alloc_qp_resc(struct bnx2i_hba *hba, struct bnx2i_endpoint *ep)
 	}
 
 	/* Allocate memory area for actual SQ element */
-	ep->qp.sq_virt =
-		dma_alloc_coherent(&hba->pcidev->dev, ep->qp.sq_mem_size,
-				   &ep->qp.sq_phys, GFP_KERNEL);
+	ep->qp.sq_virt =
+		dma_zalloc_coherent(&hba->pcidev->dev, ep->qp.sq_mem_size,
+					&ep->qp.sq_phys, GFP_KERNEL);
 	if (!ep->qp.sq_virt) {
 		printk(KERN_ALERT "bnx2i: unable to alloc SQ BD memory %d\n",
 				  ep->qp.sq_mem_size);
 		goto mem_alloc_err;
 	}
 
-	memset(ep->qp.sq_virt, 0x00, ep->qp.sq_mem_size);
 	ep->qp.sq_first_qe = ep->qp.sq_virt;
 	ep->qp.sq_prod_qe = ep->qp.sq_first_qe;
 	ep->qp.sq_cons_qe = ep->qp.sq_first_qe;
@@ -1106,15 +1105,14 @@ int bnx2i_alloc_qp_resc(struct bnx2i_hba *hba, struct bnx2i_endpoint *ep)
 	}
 
 	/* Allocate memory area for actual CQ element */
-	ep->qp.cq_virt =
-		dma_alloc_coherent(&hba->pcidev->dev, ep->qp.cq_mem_size,
-				   &ep->qp.cq_phys, GFP_KERNEL);
+	ep->qp.cq_virt =
+		dma_zalloc_coherent(&hba->pcidev->dev, ep->qp.cq_mem_size,
+					&ep->qp.cq_phys, GFP_KERNEL);
 	if (!ep->qp.cq_virt) {
 		printk(KERN_ALERT "bnx2i: unable to alloc CQ BD memory %d\n",
 				  ep->qp.cq_mem_size);
 		goto mem_alloc_err;
 	}
-	memset(ep->qp.cq_virt, 0x00, ep->qp.cq_mem_size);
 
 	ep->qp.cq_first_qe = ep->qp.cq_virt;
 	ep->qp.cq_prod_qe = ep->qp.cq_first_qe;
-- 
2.7.4

  parent reply	other threads:[~2017-12-30 15:30 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-30 15:28 [PATCH 0/9] scsi: Use zeroing allocators than allocator/memset Himanshu Jha
2017-12-30 15:28 ` [PATCH 1/9] scsi: qla4xxx: Use zeroing allocator rather " Himanshu Jha
2018-01-02  4:39   ` Rangankar, Manish
2018-01-04  6:08   ` Martin K. Petersen
2017-12-30 15:28 ` [PATCH 2/9] scsi: qla2xxx: " Himanshu Jha
2018-01-02 17:01   ` Madhani, Himanshu
2018-01-04  6:09   ` Martin K. Petersen
2017-12-30 15:28 ` [PATCH 3/9] scsi: qedi: Use zeroing allocator instead of allocator/memset Himanshu Jha
2018-01-02  4:40   ` Rangankar, Manish
2018-01-04  6:17   ` Martin K. Petersen
2017-12-30 15:28 ` [PATCH 4/9] scsi: mvsas: Use zeroing allocator rather than allocator/memset Himanshu Jha
2017-12-30 15:28 ` [PATCH 5/9] scsi: fnic: " Himanshu Jha
2017-12-30 15:28 ` [PATCH 6/9] scsi: dpt_i2o: " Himanshu Jha
2017-12-30 15:28 ` [PATCH 7/9] scsi: bnx2fc: " Himanshu Jha
2018-01-02 21:14   ` Chad Dupuis
2018-01-04  6:17   ` Martin K. Petersen
2018-01-04  7:38     ` Himanshu Jha
2018-01-09  3:35       ` Martin K. Petersen
2017-12-30 15:28 ` [PATCH 8/9] scsi: bfa: " Himanshu Jha
2018-01-02  5:40   ` Gurumurthy, Anil
2018-01-04  6:13   ` Martin K. Petersen
2017-12-30 15:28 ` Himanshu Jha [this message]
2018-01-02  4:42   ` [PATCH 9/9] scsi: bnx2i: " Rangankar, Manish
2018-01-04  6:13   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1514647712-6332-10-git-send-email-himanshujha199640@gmail.com \
    --to=himanshujha199640@gmail.com \
    --cc=QLogic-Storage-Upstream@cavium.com \
    --cc=QLogic-Storage-Upstream@qlogic.com \
    --cc=aacraid@adaptec.com \
    --cc=anil.gurumurthy@qlogic.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=kartilak@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=qla2xxx-upstream@qlogic.com \
    --cc=satishkh@cisco.com \
    --cc=sebaddel@cisco.com \
    --cc=sudarsana.kalluru@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).