From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org, torvalds@linux-foundation.org,
vinod.koul@intel.com, liam.r.girdwood@linux.intel.com,
arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 8/9] ASoC: Intel: boards: align/fix SKL/BXT/KBL Kconfigs
Date: Wed, 03 Jan 2018 19:00:29 +0200 [thread overview]
Message-ID: <1514998829.7000.587.camel@linux.intel.com> (raw)
In-Reply-To: <20180103165022.4984-9-pierre-louis.bossart@linux.intel.com>
On Wed, 2018-01-03 at 10:50 -0600, Pierre-Louis Bossart wrote:
> Also make sure same dependencies are used everywhere (only last one
> has SPI
> in addition).
A nitpick:
> config SND_SOC_INTEL_KBL_RT5663_MAX98927_MACH
> tristate "ASoC Audio driver for KBL with RT5663 and MAX98927
> in I2S Mode"
> - depends on X86_INTEL_LPSS && I2C
> - select SND_SOC_INTEL_SST
> + depends on MFD_INTEL_LPSS && I2C && ACPI
> select SND_SOC_RT5663
> select SND_SOC_MAX98927
> select SND_SOC_DMIC
> @@ -257,8 +256,7 @@ config SND_SOC_INTEL_KBL_RT5663_MAX98927_MACH
>
> config SND_SOC_INTEL_KBL_RT5663_RT5514_MAX98927_MACH
> tristate "ASoC Audio driver for KBL with RT5663, RT5514 and
> MAX98927 in I2S Mode"
> - depends on X86_INTEL_LPSS && I2C && SPI
> - select SND_SOC_INTEL_SST
> + depends on MFD_INTEL_LPSS && I2C && SPI && ACPI
Perhaps to split
depends on SPI
to separate line to follow pattern with the rest ?
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-01-03 17:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 16:50 [PATCH v2 0/9] ASoC: Intel: Kconfig+acpi fixes Pierre-Louis Bossart
2018-01-03 16:50 ` [PATCH v2 1/9] ASoC: acpi: add missing includes for non-ACPI platforms Pierre-Louis Bossart
2018-01-08 16:23 ` Applied "ASoC: acpi: add missing includes for non-ACPI platforms" to the asoc tree Mark Brown
2018-01-03 16:50 ` [PATCH v2 2/9] ASoC: Intel: Fix Kconfig with top-level selector Pierre-Louis Bossart
2018-01-08 16:22 ` Applied "ASoC: Intel: Fix Kconfig with top-level selector" to the asoc tree Mark Brown
2018-01-03 16:50 ` [PATCH v2 3/9] ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies Pierre-Louis Bossart
2018-01-08 16:22 ` Applied "ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies" to the asoc tree Mark Brown
2018-01-03 16:50 ` [PATCH v2 4/9] ASoC: Intel: document what Kconfig options do Pierre-Louis Bossart
2018-01-08 16:22 ` Applied "ASoC: Intel: document what Kconfig options do" to the asoc tree Mark Brown
2018-01-03 16:50 ` [PATCH v2 5/9] ASoC: Intel: Fix nested/unnecessary Kconfig dependencies Pierre-Louis Bossart
2018-01-03 16:56 ` Andy Shevchenko
2018-01-03 18:09 ` Andy Shevchenko
2018-01-03 16:50 ` [PATCH v2 6/9] ASoC: Intel: boards: align Kconfig dependencies for Haswell/Broadwell Pierre-Louis Bossart
2018-01-03 16:50 ` [PATCH v2 7/9] ASoC: Intel: boards: align Kconfig configurations for HiFi2 Pierre-Louis Bossart
2018-01-08 16:21 ` Applied "ASoC: Intel: boards: align Kconfig configurations for HiFi2" to the asoc tree Mark Brown
2018-01-03 16:50 ` [PATCH v2 8/9] ASoC: Intel: boards: align/fix SKL/BXT/KBL Kconfigs Pierre-Louis Bossart
2018-01-03 17:00 ` Andy Shevchenko [this message]
2018-01-03 16:50 ` [PATCH v2 9/9] ASoC: Intel: kconfig: add some comments for if symbols Pierre-Louis Bossart
2018-01-03 17:07 ` Andy Shevchenko
2018-01-03 19:25 ` Randy Dunlap
2018-01-03 19:51 ` Pierre-Louis Bossart
2018-01-03 17:09 ` [PATCH v2 0/9] ASoC: Intel: Kconfig+acpi fixes Andy Shevchenko
2018-01-03 18:52 ` Pierre-Louis Bossart
2018-01-03 19:10 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1514998829.7000.587.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).