From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751105AbeACRKj (ORCPT + 1 other); Wed, 3 Jan 2018 12:10:39 -0500 Received: from mga05.intel.com ([192.55.52.43]:36634 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750968AbeACRKi (ORCPT ); Wed, 3 Jan 2018 12:10:38 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,501,1508828400"; d="scan'208";a="7094715" Message-ID: <1514998829.7000.587.camel@linux.intel.com> Subject: Re: [PATCH v2 8/9] ASoC: Intel: boards: align/fix SKL/BXT/KBL Kconfigs From: Andy Shevchenko To: Pierre-Louis Bossart , alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, torvalds@linux-foundation.org, vinod.koul@intel.com, liam.r.girdwood@linux.intel.com, arnd@arndb.de, linux-kernel@vger.kernel.org Date: Wed, 03 Jan 2018 19:00:29 +0200 In-Reply-To: <20180103165022.4984-9-pierre-louis.bossart@linux.intel.com> References: <20180103165022.4984-1-pierre-louis.bossart@linux.intel.com> <20180103165022.4984-9-pierre-louis.bossart@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, 2018-01-03 at 10:50 -0600, Pierre-Louis Bossart wrote: > Also make sure same dependencies are used everywhere (only last one > has SPI > in addition). A nitpick: > config SND_SOC_INTEL_KBL_RT5663_MAX98927_MACH > tristate "ASoC Audio driver for KBL with RT5663 and MAX98927 > in I2S Mode" > - depends on X86_INTEL_LPSS && I2C > - select SND_SOC_INTEL_SST > + depends on MFD_INTEL_LPSS && I2C && ACPI > select SND_SOC_RT5663 > select SND_SOC_MAX98927 > select SND_SOC_DMIC > @@ -257,8 +256,7 @@ config SND_SOC_INTEL_KBL_RT5663_MAX98927_MACH > > config SND_SOC_INTEL_KBL_RT5663_RT5514_MAX98927_MACH > tristate "ASoC Audio driver for KBL with RT5663, RT5514 and > MAX98927 in I2S Mode" > - depends on X86_INTEL_LPSS && I2C && SPI > - select SND_SOC_INTEL_SST > + depends on MFD_INTEL_LPSS && I2C && SPI && ACPI Perhaps to split depends on SPI to separate line to follow pattern with the rest ? -- Andy Shevchenko Intel Finland Oy