From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751428AbeACSJs (ORCPT + 1 other); Wed, 3 Jan 2018 13:09:48 -0500 Received: from mga14.intel.com ([192.55.52.115]:25534 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750912AbeACSJr (ORCPT ); Wed, 3 Jan 2018 13:09:47 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,503,1508828400"; d="scan'208";a="16540183" Message-ID: <1515002984.7000.600.camel@linux.intel.com> Subject: Re: [PATCH v2 5/9] ASoC: Intel: Fix nested/unnecessary Kconfig dependencies From: Andy Shevchenko To: Pierre-Louis Bossart , alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, torvalds@linux-foundation.org, vinod.koul@intel.com, liam.r.girdwood@linux.intel.com, arnd@arndb.de, linux-kernel@vger.kernel.org Date: Wed, 03 Jan 2018 20:09:44 +0200 In-Reply-To: <20180103165022.4984-6-pierre-louis.bossart@linux.intel.com> References: <20180103165022.4984-1-pierre-louis.bossart@linux.intel.com> <20180103165022.4984-6-pierre-louis.bossart@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, 2018-01-03 at 10:50 -0600, Pierre-Louis Bossart wrote: > This patch fixes a number of issues: > 1. IOSF_MBI is only needed for byt-cr detection, which is only > supported > on Baytrail/Cherrytrail, move to HiFi2 config > > tristate "Intel ASoC SST driver for ACPI HiFi2 platforms > (Baytrail, Cherrytrail)" > depends on X86 && ACPI > select SND_SST_IPC_ACPI > + select IOSF_MBI > select SND_SOC_COMPRESS > select SND_SOC_ACPI_INTEL_MATCH > help A nitpick: Perhaps not to split SND_* options and thus put IOSF_MBI as last one in the list? -- Andy Shevchenko Intel Finland Oy