From: Oliver Neukum <oneukum@suse.com>
To: Mikhail Zaytsev <flashed@mail.ru>, Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 1/2] USB: serial: ark3116: Remove unused TIOCSSERIAL ioctl case.
Date: Mon, 08 Jan 2018 11:33:32 +0100 [thread overview]
Message-ID: <1515407612.29712.1.camel@suse.com> (raw)
In-Reply-To: <20180106201402.03d2ac88@debian>
Am Samstag, den 06.01.2018, 20:14 +0300 schrieb Mikhail Zaytsev:
> The patch removes unused TIOCSSERIAL ioctl case and adds the default block
> to the switch. This will make the ioctl return -ENOTTY to user space (e.g.
> setserial), because TIOCSSERIAL really isn't supported for these devices
> currently.
Hi,
this will break software that is now running on these devices,
won't it? Do you know why those devices basically ignore the
ioctl?
Regards
Oliver
next prev parent reply other threads:[~2018-01-08 10:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 17:08 [PATCH v2 0/2] USB: serial: ark3116: ioctl changes Mikhail Zaytsev
2018-01-06 17:14 ` [PATCH v2 1/2] USB: serial: ark3116: Remove unused TIOCSSERIAL ioctl case Mikhail Zaytsev
2018-01-08 10:33 ` Oliver Neukum [this message]
2018-01-08 15:28 ` Johan Hovold
2018-01-08 21:45 ` Mikhail Zaytsev
2018-01-09 11:55 ` Johan Hovold
2018-01-06 17:15 ` [PATCH v2 2/2] USB: serial: ark3116: Move TIOCGSERIAL ioctl case to function Mikhail Zaytsev
2018-01-09 11:57 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515407612.29712.1.camel@suse.com \
--to=oneukum@suse.com \
--cc=flashed@mail.ru \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox