From: "Woodhouse, David" <dwmw@amazon.co.uk>
To: "peterz@infradead.org" <peterz@infradead.org>,
"andi@firstfloor.org" <andi@firstfloor.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tim.c.chen@linux.intel.com" <tim.c.chen@linux.intel.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"pjt@google.com" <pjt@google.com>,
"dave.hansen@intel.com" <dave.hansen@intel.com>,
"luto@amacapital.net" <luto@amacapital.net>,
"gregkh@linux-foundation.org" <gregkh@linux-foundation.org>
Subject: Re: [PATCH] x86/retpoline: Avoid return buffer underflows on context switch
Date: Mon, 8 Jan 2018 22:17:19 +0000 [thread overview]
Message-ID: <1515449839.4423.37.camel@amazon.co.uk> (raw)
In-Reply-To: <20180108221121.GU29822@worktop.programming.kicks-ass.net>
[-- Attachment #1.1: Type: text/plain, Size: 950 bytes --]
On Mon, 2018-01-08 at 23:11 +0100, Peter Zijlstra wrote:
>
> So pjt did alignment, a single unroll and per discussion earlier today
> (CET) or late last night (PST), he only does 16.
Hey Intel, please tell us precisely how many RSB entries there are, on
each family of CPU... :)
> Why is none of that done here? Also, can we pretty please stop using
> those retarded number labels, they make this stuff unreadable.
>
> Also, pause is unlikely to stop speculation, that comment doesn't make
> sense. Looking at PJT's version there used to be a speculation trap in
> there, but I can't see that here.
In this particular code we don't need a speculation trap; that's
elsewhere. This one is *just* about the call stack. And the reason we
don't just have...
call . + 5
call . + 5
call . + 5
...
is because that might get interpreted as a "push %rip" and not go on
the RSB at all. Hence the 'pause' between each one.
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5210 bytes --]
[-- Attachment #2.1: Type: text/plain, Size: 197 bytes --]
Amazon Web Services UK Limited. Registered in England and Wales with registration number 08650665 and which has its registered office at 60 Holborn Viaduct, London EC1A 2FD, United Kingdom.
[-- Attachment #2.2: Type: text/html, Size: 197 bytes --]
next prev parent reply other threads:[~2018-01-08 22:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 20:15 [PATCH] x86/retpoline: Avoid return buffer underflows on context switch Andi Kleen
2018-01-08 21:38 ` David Woodhouse
2018-01-08 22:54 ` Andi Kleen
2018-01-08 22:11 ` Peter Zijlstra
2018-01-08 22:17 ` Woodhouse, David [this message]
2018-01-08 22:26 ` Peter Zijlstra
2018-01-08 23:25 ` Woodhouse, David
2018-01-08 22:25 ` Andi Kleen
2018-01-08 22:58 ` Andi Kleen
2018-01-09 0:15 ` Paul Turner
2018-01-09 0:15 ` Paul Turner
2018-01-09 0:44 ` Woodhouse, David
2018-01-09 0:48 ` David Woodhouse
2018-01-09 2:48 ` Paul Turner
2018-01-09 3:05 ` David Woodhouse
2018-01-12 11:15 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515449839.4423.37.camel@amazon.co.uk \
--to=dwmw@amazon.co.uk \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=dave.hansen@intel.com \
--cc=gregkh@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox