From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yury Norov <ynorov@caviumnetworks.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v1 1/4] bitmap: Add bitmap_zero()/bitmap_clear() test cases
Date: Wed, 10 Jan 2018 15:11:45 +0200 [thread overview]
Message-ID: <1515589905.7000.847.camel@linux.intel.com> (raw)
In-Reply-To: <20180110093405.zhz3smxy264kmghv@yury-thinkpad>
On Wed, 2018-01-10 at 12:34 +0300, Yury Norov wrote:
> Hi Andy,
>
> On Tue, Jan 09, 2018 at 07:24:27PM +0200, Andy Shevchenko wrote:
> > Explicitly test bitmap_zero() and bitmap_clear() functions.
> > + /* Known way to set all bits */
>
> Nit: if you start your comments with capital, proceed that way till
> the end.
Right, I have to keep the original style. I'll check this.
> I don't understand what patch #4 is doing in this series. At the first
> glance, it may be applied separately.
It fixes test failures found by patch 2 in the series.
The idea is similar to TDD.
> The rest is looking fine. For 1-3,
> Reviewed-by: Yury Norov <ynorov@caviumnetworks.com>
Thanks.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-01-10 13:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 17:24 [PATCH v1 1/4] bitmap: Add bitmap_zero()/bitmap_clear() test cases Andy Shevchenko
2018-01-09 17:24 ` [PATCH v1 2/4] bitmap: Add bitmap_fill()/bitmap_set() " Andy Shevchenko
2018-01-09 17:24 ` [PATCH v1 3/4] bitmap: Clean up test_zero_fill_copy() test case and rename Andy Shevchenko
2018-01-09 17:24 ` [PATCH v1 4/4] bitmap: Make bitmap_fill() and bitmap_zero() consistent Andy Shevchenko
2018-01-10 8:49 ` Yury Norov
2018-01-10 13:17 ` Andy Shevchenko
2018-01-11 11:57 ` Yury Norov
2018-01-11 12:46 ` Andy Shevchenko
2018-01-10 9:34 ` [PATCH v1 1/4] bitmap: Add bitmap_zero()/bitmap_clear() test cases Yury Norov
2018-01-10 13:11 ` Andy Shevchenko [this message]
2018-01-11 12:07 ` Yury Norov
2018-01-11 12:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515589905.7000.847.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=rdunlap@infradead.org \
--cc=ynorov@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox