From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756170AbeAJNdC (ORCPT + 1 other); Wed, 10 Jan 2018 08:33:02 -0500 Received: from mga09.intel.com ([134.134.136.24]:22334 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319AbeAJNdA (ORCPT ); Wed, 10 Jan 2018 08:33:00 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,340,1511856000"; d="scan'208";a="18978008" Message-ID: <1515590816.7000.857.camel@linux.intel.com> Subject: Re: [PATCH 2/2] platform/x86: surfacepro3: Support for wakeup from suspend-to-idle From: Andy Shevchenko To: "Rafael J. Wysocki" , Linux ACPI Cc: Darren Hart , LKML , Linux PM , Platform Driver , Valentin Manea Date: Wed, 10 Jan 2018 15:26:56 +0200 In-Reply-To: <6492549.QWquAG8VGe@aspire.rjw.lan> References: <4046497.JI7UjL75gC@aspire.rjw.lan> <6492549.QWquAG8VGe@aspire.rjw.lan> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, 2018-01-10 at 13:26 +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Modify surface_button_notify() to make it wake up the system from > suspend-to-idle (by reporting "hard" wakeup events while suspended) > and add wakeup initialization to surface_button_add() for wakeup > events reported by this driver to work at all. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=198389 > Reported-by: Valentin Manea > Signed-off-by: Rafael J. Wysocki Change seems sane to me. Acked-by: Andy Shevchenko (in case you would like to push it through PM tree, otherwise I can take it) > --- > drivers/platform/x86/surfacepro3_button.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > Index: linux-pm/drivers/platform/x86/surfacepro3_button.c > =================================================================== > --- linux-pm.orig/drivers/platform/x86/surfacepro3_button.c > +++ linux-pm/drivers/platform/x86/surfacepro3_button.c > @@ -119,7 +119,7 @@ static void surface_button_notify(struct > if (key_code == KEY_RESERVED) > return; > if (pressed) > - pm_wakeup_event(&device->dev, 0); > + pm_wakeup_dev_event(&device->dev, 0, button- > >suspended); > if (button->suspended) > return; > input_report_key(input, key_code, pressed?1:0); > @@ -185,6 +185,8 @@ static int surface_button_add(struct acp > error = input_register_device(input); > if (error) > goto err_free_input; > + > + device_init_wakeup(&device->dev, true); > dev_info(&device->dev, > "%s [%s]\n", name, acpi_device_bid(device)); > return 0; > -- Andy Shevchenko Intel Finland Oy