From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sohil Mehta <sohil.mehta@intel.com>,
Joerg Roedel <joro@8bytes.org>,
Alex Williamson <alex.williamson@redhat.com>
Cc: Ashok Raj <ashok.raj@intel.com>,
David Woodhouse <dwmw2@infradead.org>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Gayatri Kammela <gayatri.kammela@intel.com>,
Ravi V Shankar <ravi.v.shankar@intel.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
Fenghua Yu <fenghua.yu@intel.com>
Subject: Re: [PATCH v6 1/5] iommu/vt-d: Add debugfs support for Intel IOMMU internals
Date: Wed, 10 Jan 2018 15:32:46 +0200 [thread overview]
Message-ID: <1515591166.7000.860.camel@linux.intel.com> (raw)
In-Reply-To: <1515556102-34150-2-git-send-email-sohil.mehta@intel.com>
On Tue, 2018-01-09 at 19:48 -0800, Sohil Mehta wrote:
> From: Gayatri Kammela <gayatri.kammela@intel.com>
>
> Enable Intel IOMMU debug to export Intel IOMMU internals in debugfs
> +config INTEL_IOMMU_DEBUG
> + bool "Export Intel IOMMU internals in DebugFS"
> + depends on INTEL_IOMMU && DEBUG_FS
> + default n
I thought I commented on this...
Please, remove. "n" is default default, so no need to duplicate it.
> + help
> + IOMMU internal states such as context, PASID tables can be
> seen via
> + debugfs. Select this option if you want to export these
> internals.
> +
> + Say Y if you need this.
Also I lost a track how this option is being used here. It looks like
this part is not related to the patch itself.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-01-10 13:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 3:48 [PATCH v6 0/5] Add Intel IOMMU debugfs support Sohil Mehta
2018-01-10 3:48 ` [PATCH v6 1/5] iommu/vt-d: Add debugfs support for Intel IOMMU internals Sohil Mehta
2018-01-10 13:32 ` Andy Shevchenko [this message]
2018-01-10 3:48 ` [PATCH v6 2/5] iommu/vt-d: Add debugfs support to show context internals Sohil Mehta
2018-01-10 17:02 ` Gary R Hook
2018-01-10 3:48 ` [PATCH v6 3/5] iommu/vt-d: Add debugfs support to show register contents Sohil Mehta
2018-01-10 13:35 ` Andy Shevchenko
2018-01-10 3:48 ` [PATCH v6 4/5] iommu/vt-d: Add debugfs support to show Pasid table contents Sohil Mehta
2018-01-10 13:40 ` Andy Shevchenko
2018-01-10 3:48 ` [PATCH v6 5/5] iommu/vt-d: Add debugfs support for Interrupt remapping Sohil Mehta
2018-01-10 13:43 ` Andy Shevchenko
2018-01-10 13:46 ` [PATCH v6 0/5] Add Intel IOMMU debugfs support Andy Shevchenko
2018-01-11 1:32 ` Mehta, Sohil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515591166.7000.860.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=fenghua.yu@intel.com \
--cc=gayatri.kammela@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.v.shankar@intel.com \
--cc=sohil.mehta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox