From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753749AbeAJNhg (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Wed, 10 Jan 2018 08:37:36 -0500
Received: from mga11.intel.com ([192.55.52.93]:42459 "EHLO mga11.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752251AbeAJNhe (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 10 Jan 2018 08:37:34 -0500
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,340,1511856000"; 
   d="scan'208";a="18978837"
Message-ID: <1515591166.7000.860.camel@linux.intel.com>
Subject: Re: [PATCH v6 1/5] iommu/vt-d: Add debugfs support for Intel IOMMU
 internals
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sohil Mehta <sohil.mehta@intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Alex Williamson <alex.williamson@redhat.com>
Cc: Ashok Raj <ashok.raj@intel.com>,
        David Woodhouse <dwmw2@infradead.org>,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        Gayatri Kammela <gayatri.kammela@intel.com>,
        Ravi V Shankar <ravi.v.shankar@intel.com>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
Date: Wed, 10 Jan 2018 15:32:46 +0200
In-Reply-To: <1515556102-34150-2-git-send-email-sohil.mehta@intel.com>
References: <1515556102-34150-1-git-send-email-sohil.mehta@intel.com>
         <1515556102-34150-2-git-send-email-sohil.mehta@intel.com>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.26.3-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Tue, 2018-01-09 at 19:48 -0800, Sohil Mehta wrote:
> From: Gayatri Kammela <gayatri.kammela@intel.com>
> 
> Enable Intel IOMMU debug to export Intel IOMMU internals in debugfs

 
> +config INTEL_IOMMU_DEBUG
> +	bool "Export Intel IOMMU internals in DebugFS"
> +	depends on INTEL_IOMMU && DEBUG_FS

> +	default n

I thought I commented on this...

Please, remove. "n" is default default, so no need to duplicate it.

> +	help
> +	  IOMMU internal states such as context, PASID tables can be
> seen via
> +	  debugfs. Select this option if you want to export these
> internals.
> +
> +	  Say Y if you need this.

Also I lost a track how this option is being used here. It looks like
this part is not related to the patch itself.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy