From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753368AbeAKAgB (ORCPT + 1 other); Wed, 10 Jan 2018 19:36:01 -0500 Received: from mailgw02.mediatek.com ([1.203.163.81]:32967 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753226AbeAKAf7 (ORCPT ); Wed, 10 Jan 2018 19:35:59 -0500 X-UUID: 0504ace64c61488cb565c0462880ed82-20180111 Message-ID: <1515630944.19513.2.camel@mhfsdcap03> Subject: Re: [PATCH] usb: mtu3: fix ssusb_wakeup_set dummy From: Chunfeng Yun To: Arnd Bergmann CC: Greg Kroah-Hartman , Felipe Balbi , Johan Hovold , , , , Date: Thu, 11 Jan 2018 08:35:44 +0800 In-Reply-To: <20180110164530.1399750-1-arnd@arndb.de> References: <20180110164530.1399750-1-arnd@arndb.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, 2018-01-10 at 17:45 +0100, Arnd Bergmann wrote: > Changing from ssusb_wakeup_enable/disable to ssusb_wakeup_set was done > in only one of two places in the kernel, the other one now causes a > build failure: > > drivers/usb/mtu3/mtu3_plat.c: In function 'mtu3_suspend': > drivers/usb/mtu3/mtu3_plat.c:462:2: error: implicit declaration of function 'ssusb_wakeup_set'; did you mean 'ssusb_wakeup_disable'? [-Werror=implicit-function-declaration] > > This adapts the dummy helpers the same way that the extern declarations > were. > > Fixes: f0ede2c6282b ("usb: mtu3: supports remote wakeup for mt2712 with two SSUSB IPs") > Signed-off-by: Arnd Bergmann > --- > drivers/usb/mtu3/mtu3_dr.h | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/usb/mtu3/mtu3_dr.h b/drivers/usb/mtu3/mtu3_dr.h > index ae1598d76e02..50702fdcde28 100644 > --- a/drivers/usb/mtu3/mtu3_dr.h > +++ b/drivers/usb/mtu3/mtu3_dr.h > @@ -48,12 +48,7 @@ static inline int ssusb_host_disable(struct ssusb_mtk *ssusb, bool suspend) > return 0; > } > > -static inline int ssusb_wakeup_enable(struct ssusb_mtk *ssusb) > -{ > - return 0; > -} > - > -static inline void ssusb_wakeup_disable(struct ssusb_mtk *ssusb) > +static inline void ssusb_wakeup_set(struct ssusb_mtk *ssusb, bool enable) > {} > > #endif Forgot to make it change, Acked-by: Chunfeng Yun Thanks a lot