Re: [PATCH v1 1/4] bitmap: Add bitmap_zero()/bitmap_clear() test cases

Andy Shevchenko
2018-01-11T12:35:43Z

On Thu, 2018-01-11 at 15:07 +0300, Yury Norov wrote:
> On Wed, Jan 10, 2018 at 03:11:45PM +0200, Andy Shevchenko wrote:
> > On Wed, 2018-01-10 at 12:34 +0300, Yury Norov wrote:
> > >

> > > I don't understand what patch #4 is doing in this series. At the
> > > first
> > > glance, it may be applied separately.
> >
> > It fixes test failures found by patch 2 in the series.
> > The idea is similar to TDD.
>
> So with current order, patch 2 introduces regression that is fixed in
> patch 4, is my understanding correct?

I'm sorry to ask, but do you call new test cases "a regression" for
real?!

> This is not the best idea because it will break bisectability.

Huh?

--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy