From: David Woodhouse <dwmw2@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2/3] objtool: Ignore retpoline alternatives
Date: Thu, 11 Jan 2018 17:43:41 +0000 [thread overview]
Message-ID: <1515692621.22302.384.camel@infradead.org> (raw)
In-Reply-To: <CA+55aFzLA2dBhVTsvEBZ58aS2Jgp020cPC3MvMR_RuJqFmM67Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
On Thu, 2018-01-11 at 09:29 -0800, Linus Torvalds wrote:
> On Thu, Jan 11, 2018 at 8:27 AM, David Woodhouse <dwmw2@infradead.org> wrote:
> >
> >
> > Ick, numbers. Use .Lfoo_%= instead.
> >
>
> Actually, I think PeterZ is wrong on this one.
>
> First off, we do *not* use %= in inline asms in the kernel yet, and we
> shouldn't start just because of these.
>
> Secondly, we use lots of the the "small numbers for local labels" both
> in inline asm and in *.S files.
>
> I think doing
>
> jne 1f
> ...
> 1:
>
> is a _hell_ of a lot more legible than
>
> jne .LPrefix_%
> ...
> .LPrefix_%
>
> unless you have some *major* reason to use an explicit label name.
OK. I'll change it back.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]
next prev parent reply other threads:[~2018-01-11 17:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 1:48 [PATCH 0/3] objtool: retpoline compatibility Josh Poimboeuf
2018-01-11 1:48 ` [PATCH 1/3] objtool: Detect jumps to retpoline thunks Josh Poimboeuf
2018-01-11 1:48 ` [PATCH 2/3] objtool: Ignore retpoline alternatives Josh Poimboeuf
2018-01-11 16:27 ` David Woodhouse
2018-01-11 16:33 ` Josh Poimboeuf
2018-01-11 16:39 ` David Woodhouse
2018-01-11 16:48 ` Josh Poimboeuf
2018-01-11 16:55 ` David Woodhouse
2018-01-11 17:25 ` Josh Poimboeuf
2018-01-11 16:58 ` Peter Zijlstra
2018-01-11 17:05 ` Jiri Kosina
2018-01-11 17:01 ` Jiri Kosina
2018-01-11 17:05 ` Peter Zijlstra
2018-01-11 17:19 ` David Woodhouse
2018-01-11 17:23 ` Peter Zijlstra
2018-01-11 16:44 ` Peter Zijlstra
2018-01-11 17:29 ` Linus Torvalds
2018-01-11 17:37 ` Josh Poimboeuf
2018-01-11 17:43 ` David Woodhouse [this message]
2018-01-11 17:56 ` Peter Zijlstra
2018-01-12 20:36 ` Ingo Molnar
2018-01-11 17:57 ` David Woodhouse
2018-01-11 1:48 ` [PATCH 3/3] Revert "x86/retpoline: Temporarily disable objtool when CONFIG_RETPOLINE=y" Josh Poimboeuf
2018-01-11 10:22 ` [PATCH 0/3] objtool: retpoline compatibility David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515692621.22302.384.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox