From: Joe Perches <joe@perches.com>
To: Naveen Panwar <naveen.panwar27@gmail.com>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: netlogic: platform_net: Fixed '(' at the EOL
Date: Sun, 14 Jan 2018 10:44:20 -0800 [thread overview]
Message-ID: <1515955460.12444.11.camel@perches.com> (raw)
In-Reply-To: <1515953831-11483-1-git-send-email-naveen.panwar27@gmail.com>
On Sun, 2018-01-14 at 23:47 +0530, Naveen Panwar wrote:
> Removed '(' from the end of line, coding style issue.
[]
> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
[]
> @@ -107,8 +107,8 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
> .dev.platform_data = &ndata1,
> };
>
> - gmac4_addr = ioremap(CPHYSADDR(
> - nlm_mmio_base(NETLOGIC_IO_GMAC_4_OFFSET)), 0xfff);
> + gmac4_addr = ioremap(CPHYSADDR
> + (nlm_mmio_base(NETLOGIC_IO_GMAC_4_OFFSET)), 0xfff);
My first reaction is this is ugly.
I suggest
gmac4_addr = ioremap(CPHYSADDR(nlm_mmio_base(NETLOGIC_IO_GMAC_4_OFFSET)),
0xfff);
or using a temporary or a #define for
CPHYSADDR(nlm_mmio_base(NETLOGIC_IO_GMAC_4_OFFSET))
or add a new define like:
#define MMIO_CPHYSADDR(addr) (CPHYSADDR(nlm_mmio_base(addr)))
and change all the netlogic uses of CPHYSADDR so this one
could be
gmac4_addr = ioremap(MMIO_CPHYSADDR(NETLOGIC_IO_GMAC_4_OFFSET), 0xfff);
etc...
next prev parent reply other threads:[~2018-01-14 18:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 18:17 [PATCH] Staging: netlogic: platform_net: Fixed '(' at the EOL Naveen Panwar
2018-01-14 18:44 ` Joe Perches [this message]
2018-01-14 20:10 ` Al Viro
2018-01-14 20:22 ` Joe Perches
2018-01-15 6:01 ` Naveen Panwar
2018-01-16 14:03 ` Naveen Panwar
2018-01-16 14:29 ` Dan Carpenter
2018-01-16 15:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515955460.12444.11.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.panwar27@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox