From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752039AbeANSoY (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Sun, 14 Jan 2018 13:44:24 -0500
Received: from smtprelay0173.hostedemail.com ([216.40.44.173]:57667 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751493AbeANSoX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 14 Jan 2018 13:44:23 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-HE-Tag: ray50_43243c34e033b
X-Filterd-Recvd-Size: 1854
Message-ID: <1515955460.12444.11.camel@perches.com>
Subject: Re: [PATCH] Staging: netlogic: platform_net: Fixed '(' at the EOL
From: Joe Perches <joe@perches.com>
To: Naveen Panwar <naveen.panwar27@gmail.com>,
        gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Sun, 14 Jan 2018 10:44:20 -0800
In-Reply-To: <1515953831-11483-1-git-send-email-naveen.panwar27@gmail.com>
References: <1515953831-11483-1-git-send-email-naveen.panwar27@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.26.1-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Sun, 2018-01-14 at 23:47 +0530, Naveen Panwar wrote:
> Removed '(' from the end of line, coding style issue.
[]
> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
[]
> @@ -107,8 +107,8 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
>  		.dev.platform_data = &ndata1,
>  	};
>  
> -	gmac4_addr = ioremap(CPHYSADDR(
> -		nlm_mmio_base(NETLOGIC_IO_GMAC_4_OFFSET)), 0xfff);
> +	gmac4_addr = ioremap(CPHYSADDR
> +			(nlm_mmio_base(NETLOGIC_IO_GMAC_4_OFFSET)), 0xfff);

My first reaction is this is ugly.

I suggest
	gmac4_addr = ioremap(CPHYSADDR(nlm_mmio_base(NETLOGIC_IO_GMAC_4_OFFSET)),
			     0xfff);

or using a temporary or a #define for
	CPHYSADDR(nlm_mmio_base(NETLOGIC_IO_GMAC_4_OFFSET))

or add a new define like:

#define MMIO_CPHYSADDR(addr) (CPHYSADDR(nlm_mmio_base(addr)))

and change all the netlogic uses of CPHYSADDR so this one
could be

	gmac4_addr = ioremap(MMIO_CPHYSADDR(NETLOGIC_IO_GMAC_4_OFFSET), 0xfff);

etc...