From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752192AbeANUWL (ORCPT + 1 other); Sun, 14 Jan 2018 15:22:11 -0500 Received: from smtprelay0205.hostedemail.com ([216.40.44.205]:57752 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751259AbeANUWK (ORCPT ); Sun, 14 Jan 2018 15:22:10 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: test10_2fb2efbf2c661 X-Filterd-Recvd-Size: 1931 Message-ID: <1515961326.3045.8.camel@perches.com> Subject: Re: [PATCH] Staging: netlogic: platform_net: Fixed '(' at the EOL From: Joe Perches To: Al Viro , Naveen Panwar Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-doc , Dan Carpenter , Jonathan Corbet Date: Sun, 14 Jan 2018 12:22:06 -0800 In-Reply-To: <20180114201008.GM13338@ZenIV.linux.org.uk> References: <1515953831-11483-1-git-send-email-naveen.panwar27@gmail.com> <20180114201008.GM13338@ZenIV.linux.org.uk> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Sun, 2018-01-14 at 20:10 +0000, Al Viro wrote: > On Sun, Jan 14, 2018 at 11:47:11PM +0530, Naveen Panwar wrote: > > Removed '(' from the end of line, coding style issue. > > The one and only reason for warnings is that they point to > places more likely to be dodgy. There is no inherent value > in having e.g. checkpatch.pl STFU, all wanking about uniformity > of style nonwithstanding. [ long and complete response removed, available at https://patchwork.kernel.org/patch/10162725/ ] It was very generous of you to spend so much time on that informative and thorough reply Al. My own response was _much_ more terse. What I wonder is if that sort of guided response can be setup as documentation for kernel-newbies / janitors so that future new submitters can have better ideas as to what code can and should be improved instead of getting simple and sometimes ill-advised whitespace changes. cheers, Joe