From: Joe Perches <joe@perches.com>
To: Crt Mori <cmo@melexis.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Ian Abbott <abbotti@mev.co.uk>,
Larry Finger <Larry.Finger@lwfinger.net>,
Niklas Soderlund <niklas.soderlund+renesas@ragnatech.se>,
Thomas Gleixner <tglx@linutronix.de>,
Krzysztof Kozlowski <krzk@kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-kernel@vger.kernel.org,
Linux Iio <linux-iio@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
David Laight <David.Laight@aculab.com>
Subject: Re: [PATCH v12 1/3] lib: Add strongly typed 64bit int_sqrt
Date: Mon, 15 Jan 2018 02:36:15 -0800 [thread overview]
Message-ID: <1516012575.3045.37.camel@perches.com> (raw)
In-Reply-To: <CAKv63uvq5Eq9f9VNSufUmJCOsd4vebbSu2V0Jzbmgth3vbJ9Dw@mail.gmail.com>
On Wed, 2018-01-10 at 09:37 +0100, Crt Mori wrote:
> Shouldn't I rather make it
>
> if (x <= ULONG_MAX)
> return int_sqrt((unsigned long) x);
With this change: (I believe done in v13) and
as requested by Crt Mori in a private email:
Acked-by: Joe Perches <joe@perches.com>
next prev parent reply other threads:[~2018-01-15 10:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 15:18 [PATCH v12 1/3] lib: Add strongly typed 64bit int_sqrt Crt Mori
2018-01-09 19:23 ` Joe Perches
2018-01-10 8:15 ` Crt Mori
2018-01-10 8:33 ` Crt Mori
2018-01-10 8:37 ` Crt Mori
2018-01-15 10:36 ` Joe Perches [this message]
2018-02-04 10:19 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516012575.3045.37.camel@perches.com \
--to=joe@perches.com \
--cc=David.Laight@aculab.com \
--cc=Larry.Finger@lwfinger.net \
--cc=abbotti@mev.co.uk \
--cc=akpm@linux-foundation.org \
--cc=cmo@melexis.com \
--cc=jic23@kernel.org \
--cc=keescook@chromium.org \
--cc=krzk@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=peterz@infradead.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).