From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932397AbeAOLdv (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Mon, 15 Jan 2018 06:33:51 -0500
Received: from mga01.intel.com ([192.55.52.88]:42835 "EHLO mga01.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932121AbeAOLdt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 15 Jan 2018 06:33:49 -0500
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,363,1511856000"; 
   d="scan'208";a="10364424"
Message-ID: <1516016025.7000.992.camel@linux.intel.com>
Subject: Re: [PATCH] ACPI / LPSS: Do not instiate a platform_dev for devs
 without a mmio resource
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Chen-Yu Tsai <wens@csie.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        linux-pwm@vger.kernel.org, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Mon, 15 Jan 2018 13:33:45 +0200
In-Reply-To: <20180115093615.GA27654@lahna.fi.intel.com>
References: <20180114200148.11771-1-hdegoede@redhat.com>
         <20180115093615.GA27654@lahna.fi.intel.com>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.26.3-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Mon, 2018-01-15 at 11:36 +0200, Mika Westerberg wrote:
> On Sun, Jan 14, 2018 at 09:01:48PM +0100, Hans de Goede wrote:
> > acpi_lpss_create_device() skips handling LPSS devices which do not
> > have
> > a mmio resources in their resource list (typically these devices are
> > disabled by the firmware). But since the LPSS code does not bind to
> > the
> > device, acpi_bus_attach() ends up still creating a platform device
> > for
> > it and the regular platform_driver for the ACPI HID still tries to
> > bind
> > to it.
> > 
> > This happens e.g. on some boards which do not use the pwm-controller
> > and have an empty or invalid resource-table for it. Currently this
> > causes
> > these error messages to get logged:
> > [    3.281966] pwm-lpss 80862288:00: invalid resource
> > [    3.287098] pwm-lpss: probe of 80862288:00 failed with error -22
> > 
> > This commit stops the undesirable creation of a platform_device for
> > disabled LPSS devices by setting pnp.type.platform_id to 0. Note
> > that
> > acpi_scan_attach_handler() also sets pnp.type.platform_id to 0 when
> > there
> > is a matching handler for the device and that handler has no attach
> > callback, so we simply behave as a handler without an attach
> > function
> > in this case.
> > 
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
> Seems like a good way to fix it IMHO,

Yeah, looks much better for my opinion than previous hack to PWM
platform driver.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy