From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751475AbeAOSPJ (ORCPT + 1 other); Mon, 15 Jan 2018 13:15:09 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:45852 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255AbeAOSNc (ORCPT ); Mon, 15 Jan 2018 13:13:32 -0500 X-Google-Smtp-Source: ACJfBovLtdZZqXmXZzChdhrO4EXKeI2YE8k1i05r8mgmxtwfa3M4e/lAI8xc7q4+TsmBfQR5tu8fzg== Message-ID: <1516040009.2762.2.camel@arista.com> Subject: Re: [PATCH 3/5] pktgen: Add behavior flag names array - pkt_flag_names From: Dmitry Safonov To: David Miller Cc: linux-kernel@vger.kernel.org, 0x7f454c46@gmail.com, arnd@arndb.de, dwindsor@gmail.com, edumazet@google.com, mingo@kernel.org, johannes.berg@intel.com, mark.rutland@arm.com, rrendec@arista.com, elena.reshetova@intel.com, netdev@vger.kernel.org Date: Mon, 15 Jan 2018 18:13:29 +0000 In-Reply-To: <20180115.130936.1345693036896474880.davem@davemloft.net> References: <20180109135535.15237-1-dima@arista.com> <20180109135535.15237-4-dima@arista.com> <20180115.130936.1345693036896474880.davem@davemloft.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.24.6 (3.24.6-1.fc26) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, 2018-01-15 at 13:09 -0500, David Miller wrote: > From: Dmitry Safonov > Date: Tue, 9 Jan 2018 13:55:33 +0000 > > > +#define pf(flag) __stringify(flag), > > +char *pkt_flag_names[] = { > > + PKT_FLAGS > > +}; > > +#undef pf > > This should be static, also you don't use this table in this patch. > You > should add the table in the patch that actually uses the table. Sure, will do. -- Thanks, Dmitry