From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dima@arista.com>
ARC-Seal: i=1; a=rsa-sha256; t=1516314485; cv=none;
        d=google.com; s=arc-20160816;
        b=FMrxzqmblkfuf18izoUw2/tiSTaqHe/afVtAyXdHQW5aflaaxT0F5lvd8lhSRvjOKB
         Vq90lXJSMwRd1ITYwM2h0HRasBrGhF+Xj/YNBm68jWHVIDJ/kRH23p389K46DgLPI5vB
         4kjUHsiwOYw+fpLTy3JS4rFGXIvBH4419ir5sBsKw/nOzh+B2H+tAhTEUxR5jZd0k2Fx
         nga/n1GdLvakvq//q7azgiEDJ3ZEbYvjZW9MI5niM7dH1g4DiI7vFHAs07ebaJJKdSxX
         7304E8E3rbOKIgLJP5944E7Y/Bs0AfNZQ8v48Skbc+hgFt4Z9WRNIl7OIgofWNXLgV3q
         thYg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=content-transfer-encoding:mime-version:references:in-reply-to:date
         :cc:to:from:subject:message-id:dkim-signature
         :arc-authentication-results;
        bh=XhgxqJQxKeYSExuE9UJek06YMTmz3NKnqwcTljUJUDc=;
        b=wEmKaPGFL7ps5t7Qsuw0t1fxBhMQn82GJzqV9hrXntR2IBPnkS8em8Bumdg+JNK6nr
         EQf9YTDwabKt5vdeXa9L8+aM2jgiRkd0CHfQ3yjSMgJTvMVAvj2bQbWqGxe0TWf3nuKs
         ScEHJWVB+1ulEpl8ZLNevqRKZosphxuYH0uLNfhjxNTKJQYmEekRZdl8rWyTvu3y6xAS
         wpO7O6mGTpPzAweiOkysZE3cKT57qnm9um1SQiABJ/D5IXSgZRfjqdXbymTW6JPd8lyH
         GeVfqhdLmvHMF9NlgYA3a/ggmtAtHGGmIwzQPCwJ3p9gQcO++RtL4Iq9DqaoZsmvP331
         pFPg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@arista.com header.s=google header.b=ML7i99xf;
       spf=pass (google.com: domain of dima@arista.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dima@arista.com;
       dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=arista.com
Authentication-Results: mx.google.com;
       dkim=pass header.i=@arista.com header.s=google header.b=ML7i99xf;
       spf=pass (google.com: domain of dima@arista.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dima@arista.com;
       dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=arista.com
X-Google-Smtp-Source: ACJfBotLWsnp/IdlWCrYoP4kZ4wM8KGeg/LeQIWSMHtsVjX/N7vlQKedgd3UykkOTjFDxWX9lC6JfA==
Message-ID: <1516314483.2762.13.camel@arista.com>
Subject: Re: [PATCH] selftests/x86: Add <test_name>{,_32,_64} targets
From: Dmitry Safonov <dima@arista.com>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>, Andy Lutomirski <luto@kernel.org>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Shuah Khan <shuah@kernel.org>,
 Thomas Gleixner <tglx@linutronix.de>,  linux-kselftest@vger.kernel.org,
 x86@kernel.org
Date: Thu, 18 Jan 2018 22:28:03 +0000
In-Reply-To: <20180118221943.23558-1-dima@arista.com>
References: <20180118221943.23558-1-dima@arista.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.24.6 (3.24.6-1.fc26) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1589970455221827423?=
X-GMAIL-MSGID: =?utf-8?q?1589970978173248975?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On Thu, 2018-01-18 at 22:19 +0000, Dmitry Safonov wrote:
> One can only use `make all` or `make <test_name>_<bitness>`
> as make targets.
> `make <test_name>` doesn't work as Ingo noticed:
>   x86> make test_vsyscall
>   gcc -O2 -g -std=gnu99 -pthread -Wall -no-pie test_vsyscall.c -o
> test_vsyscall
>   /tmp/aBaoo3nb.o: In function `init_vdso':
>   test_vsyscall.c:68: undefined reference to `dlopen'
>   test_vsyscall.c:76: undefined reference to `dlsym'
>   test_vsyscall.c:80: undefined reference to `dlsym'
>   test_vsyscall.c:84: undefined reference to `dlsym'
>   test_vsyscall.c:88: undefined reference to `dlsym'
>   test_vsyscall.c:70: undefined reference to `dlopen'
>   collect2: error: ld returned 1 exit status
>   <builtin>: recipe for target 'test_vsyscall' failed
>   make: *** [test_vsyscall] Error 1
> 
> Makefile target substitution neither works :-/
> 
> Generate .PHONY targets per-test and fix target substitution.
> 
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: linux-kselftest@vger.kernel.org
> Cc: x86@kernel.org
> Reported-by: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Dmitry Safonov <dima@arista.com>
> ---

Drop this one, please, I've sent v2 with $(1) and $(1)_{64,32}
targets specified on one line.

-- 
Thanks,
             Dmitry