From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2838733-1516323986-2-15647682874908574415 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, FREEMAIL_FORGED_FROMDOMAIN 0.25, FREEMAIL_FROM 0.001, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='UTF-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516323986; b=QcNfDKtISbUxgf8fKg8t9XwnA6rUsk2gXKPVLb7XaXbhkMN ydCOO2e0xrRF+RgBJhNYi+e+9MSyeCdv7zuj5pqCkjX+ziAHfHRylDXhWmMJJ+2z PbvjyUGDTjhqb36cpo78jBzWbh8YrzXPFRvKjoIP6pMugunvOGZ4eUr4oT29WDTd IIWn5BscwV8uUYUzPN9dDoN9djNOa3v+nP53Zy1nobjyjEftvaGY9WdEFlUlBD28 cpaoTyiTsAhkYl3elJq9m1t5kqPYlKMfcnjOqPl7OjUU7c9VMT89dczpbQKlMlTL XDt3z71L8MaP6xSl1CvNX8J8Es72ELXHZ38QN6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=message-id:subject:from:to:cc:date :in-reply-to:references:content-type:mime-version :content-transfer-encoding:sender:list-id; s=arctest; t= 1516323986; bh=92O7hPCcBzNPrCQjluPgcnVYiEtUwDh8H2x7QzVZUMo=; b=k WKECKFl5bsNAGHo57SUGwywDujRYTUelnTgum9Pn1whMIQq/RuRcANW58xd/ce5W GQB/sNezK+ogdmBPArG8Xj0e06+Ps+9jGQ2szqBrwPFqzFJNGurBgFYNq0cXjsv5 bEi1AxDYHdQGy3h7k/wvGl+e3AW4Ha3mon/3oxjmap+zUiBPVMsjCsXWqQJlJh8g iKLvPDSpDAfdQW27ox+Z8orSKnAztpDDYxSUjYUNKP37eghOnvsviC8R7gRz/hXo uRs4XArCzlzfVvIChjsEfgP0SHD6ewP1KwFihPGaxzs4JsoMwobOg/KGOolsoQ9C KlXH2OS0DnHKygRf97QyA== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=pass (2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=Ta3mmgcc x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=pass (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=h5vECF+h; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=gmail.com header.result=pass header_is_org_domain=yes Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=pass (2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=Ta3mmgcc x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=pass (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=h5vECF+h; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=gmail.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753570AbeASBGX (ORCPT ); Thu, 18 Jan 2018 20:06:23 -0500 Received: from mail-ua0-f193.google.com ([209.85.217.193]:40551 "EHLO mail-ua0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753476AbeASBGW (ORCPT ); Thu, 18 Jan 2018 20:06:22 -0500 X-Google-Smtp-Source: ACJfBovYk8YC5n8+cmJAFsT6PwetmySiMRWGo65xq/xHYtb7/Psk8kmB+BjGwGhshidMAGDqnYuNPw== Message-ID: <1516323951.2814.2.camel@gmail.com> Subject: Re: [PATCH 1/3] Input: synaptics_rmi4 - do not delete interrupt memory too early From: thatslyude@gmail.com To: Dmitry Torokhov , Benjamin Tissoires , Damjan Georgievski Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Duggan , stable@vger.kernel.org Date: Thu, 18 Jan 2018 20:05:51 -0500 In-Reply-To: <20180119004955.247190-2-dmitry.torokhov@gmail.com> References: <20180119004955.247190-1-dmitry.torokhov@gmail.com> <20180119004955.247190-2-dmitry.torokhov@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.4 (3.26.4-1.fc27) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Reviewed-by: Lyude Paul (hope you don't mind that I'm using my gmail address for this ;) On Thu, 2018-01-18 at 16:49 -0800, Dmitry Torokhov wrote: > We want to free memory reserved for interrupt mask handling only after we > free functions, as function drivers might want to mask interrupts. This is > needed for the followup patch to the F03 that would implement unmasking and > masking interrupts from the serio pass-through port open() and close() > methods. > > Cc: stable@vger.kernel.org > Signed-off-by: Dmitry Torokhov > --- > drivers/input/rmi4/rmi_driver.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/input/rmi4/rmi_driver.c > b/drivers/input/rmi4/rmi_driver.c > index 27791d6546c66..ce3ede289ed04 100644 > --- a/drivers/input/rmi4/rmi_driver.c > +++ b/drivers/input/rmi4/rmi_driver.c > @@ -41,6 +41,13 @@ void rmi_free_function_list(struct rmi_device *rmi_dev) > > rmi_dbg(RMI_DEBUG_CORE, &rmi_dev->dev, "Freeing function list\n"); > > + /* Doing it in the reverse order so F01 will be removed last */ > + list_for_each_entry_safe_reverse(fn, tmp, > + &data->function_list, node) { > + list_del(&fn->node); > + rmi_unregister_function(fn); > + } > + > devm_kfree(&rmi_dev->dev, data->irq_memory); > data->irq_memory = NULL; > data->irq_status = NULL; > @@ -50,13 +57,6 @@ void rmi_free_function_list(struct rmi_device *rmi_dev) > > data->f01_container = NULL; > data->f34_container = NULL; > - > - /* Doing it in the reverse order so F01 will be removed last */ > - list_for_each_entry_safe_reverse(fn, tmp, > - &data->function_list, node) { > - list_del(&fn->node); > - rmi_unregister_function(fn); > - } > } > > static int reset_one_function(struct rmi_function *fn)