From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-518464-1516575966-2-9828080676407811671 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='uk', MailFrom='org' X-Spam-charsets: plain='UTF-8' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516575966; b=qKX4FZLGctrcWTFHnUzj2lOp3PgM7e4EA00Lkd+u6pXHUZh wrbtLo5gEkZ/OCFi9/8L79IBRPtqcEMiupCnGGWyaH7nqFyjKm3ncc+Jkp01opsQ 4PdG3eAovOqmD/8gk7Xs27gmuLKZOV52In95jSqf8W5hzs/bp87nn8Ng5Nl1J+If sDiWsEnNyl7Yl14MC+y7vJ3HeR+osi6e+uzp8PIsVLfImBaxIE/R6LoX/AFiBXH4 ms+R0wpnAWEBB/2aq8FrWt1UIGUzNX5s6x0JuznD8fWDmchVrJh2akUPikUiuUHw UI8DV3S3xZClotaGfHd98BOQtckKptStzTxLHfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=message-id:subject:from:to:cc:date :in-reply-to:references:content-type:mime-version :content-transfer-encoding:sender:list-id; s=arctest; t= 1516575966; bh=JuqCNsY2/cPp2YsQ2cjhKm6WUbWBAFuYM4gkIi18hmA=; b=F ZAgk26gtnSmCYcXihspVEQH0rCfAYib/xq+iZD9HEK+BLcYszkWcZ7sANSBpcAM1 Q9gSNQsQZlsUmx2LXK+uTudYhkkVrVKyRYAOTWQ6Q29qqMxO+JItSNCMDc+VJXvM 2XxZiHxB8OWaks3T2LuZ5dn+ElOn2Sf7iyuG5+m2J4/FaW0LMtXKkQ4qDIX6UK5h O6UXMzlRfhKFJNrjAvJDUHWI/OnOAqinzRU/HYvyjM9uuh/SqCG2qJUoXWZuzK7V 4epg3pe9jXFC7xzBGnYY3c2cjv+I0tpa0sgjjuQzgJc5Q7HlgtKNRJz2RQgc2eG3 R+sx3JkiXIXvRWzlq5gLw== ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=fail (p=none,has-list-id=yes,d=none) header.from=codethink.co.uk; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=codethink.co.uk header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=fail (p=none,has-list-id=yes,d=none) header.from=codethink.co.uk; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=codethink.co.uk header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751111AbeAUXGD (ORCPT ); Sun, 21 Jan 2018 18:06:03 -0500 Received: from imap1.codethink.co.uk ([176.9.8.82]:41999 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751106AbeAUXGD (ORCPT ); Sun, 21 Jan 2018 18:06:03 -0500 Message-ID: <1516575958.3417.22.camel@codethink.co.uk> Subject: Re: [PATCH 4.4 39/63] net: reevalulate autoflowlabel setting after sysctl setting From: Ben Hutchings To: Shaohua Li Cc: stable@vger.kernel.org, Martin KaFai Lau , Eric Dumazet , Tom Herbert , "David S. Miller" , Greg Kroah-Hartman , LKML Date: Sun, 21 Jan 2018 23:05:58 +0000 In-Reply-To: <20180101140049.154545057@linuxfoundation.org> References: <20180101140042.456380281@linuxfoundation.org> <20180101140049.154545057@linuxfoundation.org> Organization: Codethink Ltd. Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, 2018-01-01 at 15:24 +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch.  If anyone has any objections, please let me know. > > ------------------ > > From: Shaohua Li > > > [ Upstream commit 513674b5a2c9c7a67501506419da5c3c77ac6f08 ] [...] > Note, this changes behavior a little bit. Before commit 42240901f7c4 > (ipv6: Implement different admin modes for automatic flow labels), the > autoflowlabel behavior of a sock isn't sticky, eg, if sysctl changes, > existing connection will change autoflowlabel behavior. After that > commit, autoflowlabel behavior is sticky in the whole life of the sock. > With this patch, the behavior isn't sticky again. [...] I think the getsockopt() handling for IPV6_AUTOFLOWLABEL also needs to be updated, as it will now return 0 unless the option has been explicitly set. Ben. -- Ben Hutchings Software Developer, Codethink Ltd.