From: Marco Martin <notmart@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: mjg59@srcf.ucam.org, pali.rohar@gmail.com, dvhart@infradead.org,
andy@infradead.org, bhush94@gmail.com,
platform-driver-x86@vger.kernel.org, mario.limonciello@dell.com,
Marco Martin <notmart@gmail.com>,
Mario Limonciello <mario_limonciello@dell.com>
Subject: [PATCH] Support intel-vbtn based tablet mode switch
Date: Mon, 22 Jan 2018 13:48:01 +0100 [thread overview]
Message-ID: <1516625281-16547-1-git-send-email-notmart@gmail.com> (raw)
some laptops such as Dell Inspiron 7000 series have the
tablet mode switch implemented in intel acpi,
the events to enter and exit the tablet mode are 0xCC and 0xCD
CC: platform-driver-x86@vger.kernel.org
CC: Matthew Garrett <mjg59@srcf.ucam.org>
CC: "Pali Rohár" <pali.rohar@gmail.com>
CC: Darren Hart <dvhart@infradead.org>
CC: Mario Limonciello <mario_limonciello@dell.com>
CC: Andy Shevchenko <andy@infradead.org>
Signed-off-by: Marco Martin <notmart@gmail.com>
---
drivers/platform/x86/intel-vbtn.c | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
index 4809267..c4362df 100644
--- a/drivers/platform/x86/intel-vbtn.c
+++ b/drivers/platform/x86/intel-vbtn.c
@@ -26,6 +26,9 @@
#include <linux/suspend.h>
#include <acpi/acpi_bus.h>
+/* When NOT in tablet mode, VBDS has the flag 0x40 */
+#define TABLET_MODE_FLAG 0x40
+
MODULE_LICENSE("GPL");
MODULE_AUTHOR("AceLan Kao");
@@ -42,6 +45,8 @@ static const struct key_entry intel_vbtn_keymap[] = {
{ KE_IGNORE, 0xC5, { KEY_VOLUMEUP } }, /* volume-up key release */
{ KE_KEY, 0xC6, { KEY_VOLUMEDOWN } }, /* volume-down key press */
{ KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key release */
+ { KE_SW, 0xCC, { .sw = { SW_TABLET_MODE, 1 } } }, /* Tabletmode in */
+ { KE_SW, 0xCD, { .sw = { SW_TABLET_MODE, 0 } } }, /* Tabletmode out */
{ KE_END },
};
@@ -81,6 +86,7 @@ static void notify_handler(acpi_handle handle, u32 event, void *context)
return;
}
} else if (sparse_keymap_report_event(priv->input_dev, event, 1, true)) {
+ input_sync(priv->input_dev);
return;
}
dev_info(&device->dev, "unknown event index 0x%x\n", event);
@@ -92,6 +98,7 @@ static int intel_vbtn_probe(struct platform_device *device)
struct intel_vbtn_priv *priv;
acpi_status status;
int err;
+ struct acpi_buffer vgbs_output = { ACPI_ALLOCATE_BUFFER, NULL };
status = acpi_evaluate_object(handle, "VBDL", NULL, NULL);
if (ACPI_FAILURE(status)) {
@@ -110,6 +117,27 @@ static int intel_vbtn_probe(struct platform_device *device)
return err;
}
+ status = acpi_evaluate_object(handle, "VGBS", NULL, &vgbs_output);
+ /* VGBS being present and returning something means
+ * we have a tablet mode switch
+ */
+ if (ACPI_SUCCESS(status)) {
+ union acpi_object *obj = vgbs_output.pointer;
+
+ input_set_capability(priv->input_dev, EV_SW, SW_TABLET_MODE);
+
+ if (obj && obj->type == ACPI_TYPE_INTEGER) {
+ if (obj->integer.value & TABLET_MODE_FLAG)
+ input_report_switch(priv->input_dev,
+ SW_TABLET_MODE,
+ 0);
+ else
+ input_report_switch(priv->input_dev,
+ SW_TABLET_MODE,
+ 1);
+ }
+ }
+
status = acpi_install_notify_handler(handle,
ACPI_DEVICE_NOTIFY,
notify_handler,
--
2.7.4
next reply other threads:[~2018-01-22 12:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 12:48 Marco Martin [this message]
2018-01-22 13:42 ` [PATCH] Support intel-vbtn based tablet mode switch Andy Shevchenko
2018-01-22 13:52 ` Marco Martin
2018-01-22 14:46 ` Andy Shevchenko
2018-01-22 23:46 ` Dmitry Torokhov
2018-01-23 12:42 ` Marco Martin
-- strict thread matches above, loose matches on Subject: below --
2018-01-23 15:17 Marco Martin
2018-01-29 20:27 Marco Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516625281-16547-1-git-send-email-notmart@gmail.com \
--to=notmart@gmail.com \
--cc=andy@infradead.org \
--cc=bhush94@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=mario_limonciello@dell.com \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox