From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751115AbeAVUmJ (ORCPT ); Mon, 22 Jan 2018 15:42:09 -0500 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:3940 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750892AbeAVUmH (ORCPT ); Mon, 22 Jan 2018 15:42:07 -0500 X-IronPort-AV: E=Sophos;i="5.46,398,1511798400"; d="scan'208";a="70180876" From: Bart Van Assche To: "joe@perches.com" , "jthumshirn@suse.de" , "axboe@fb.com" CC: "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" Subject: Re: [PATCH TRIVIAL] bsg: use pr_debug instead of hand crafted macros Thread-Topic: [PATCH TRIVIAL] bsg: use pr_debug instead of hand crafted macros Thread-Index: AQHTk1Yw/fXVLTHK90GhU1OcYhL0TKOAVyaAgAAFGIA= Date: Mon, 22 Jan 2018 20:42:04 +0000 Message-ID: <1516653723.2545.37.camel@wdc.com> References: <20180122075348.6974-1-jthumshirn@suse.de> <1516652629.8378.14.camel@perches.com> In-Reply-To: <1516652629.8378.14.camel@perches.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [199.255.44.172] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1051;7:/oHzraSLNl5WfQmlHup6BbEmJtDM2vi/N0Nh94zk5VS7h3JzK9+A6HlPKbY+M44JlBG//VOsfv4nDvsJOSy6EmLdJuSWnG/wfGwU3G2bRYG2wY9XOjQyoNKX1A2Fzen3V0FWZ41PuBWrPr4/fu+lWHaFTBLx+VoKPY7lji7rRFvMt4Sxrc3n5S16lUYRG6Ahk4Yi1FPphygXiRyfsjEanLhzX69Podhl4tptYbdmoc+FL6vTncyJrULoYmnO3WJt;20:Mq7OZSQrb3vcjFkUeEiqGlJ0c2Q9nBvKhJB76meivWllBpdVp7XdQntjWix2NglVb/HUwJ/EO6/bFgp7kRvXdgTJvjlyYgPOfAjzZx4C4oYWqcjlqz+LnXHtHAwPphM7nv44WxFiWmLbJEfVGpsnPEQOH9fvfpdh4eGCEJb6a+k= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: d26ecc73-d8fd-4c3a-7d8c-08d561d898f1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(48565401081)(2017052603307)(7153060)(7193020);SRVR:CY1PR0401MB1051; x-ms-traffictypediagnostic: CY1PR0401MB1051: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(3231023)(2400081)(944501161)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041288)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(6072148)(201708071742011);SRVR:CY1PR0401MB1051;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CY1PR0401MB1051; x-forefront-prvs: 0560A2214D x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39380400002)(39860400002)(376002)(366004)(346002)(396003)(189003)(199004)(377424004)(3280700002)(3846002)(2950100002)(316002)(7736002)(229853002)(6486002)(110136005)(2900100001)(305945005)(103116003)(6116002)(54906003)(36756003)(106356001)(5660300001)(105586002)(81166006)(99286004)(25786009)(2501003)(478600001)(68736007)(2201001)(26005)(97736004)(76176011)(66066001)(14454004)(72206003)(4326008)(6246003)(3660700001)(53936002)(8676002)(8936002)(2906002)(81156014)(86362001)(6512007)(6506007)(102836004)(77096007)(6436002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1051;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: SkU6Vc+A598lqp4BrWTMYx1KDvTLn9ynztaPsspPFlmOOOhY1TDTDkW9MU2NbvRuwU8yRgVNz0uwLltRH809BQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: d26ecc73-d8fd-4c3a-7d8c-08d561d898f1 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2018 20:42:04.8961 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1051 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w0MKgFvX002618 On Mon, 2018-01-22 at 12:23 -0800, Joe Perches wrote: > On Mon, 2018-01-22 at 08:53 +0100, Johannes Thumshirn wrote: > > Use pr_debug instead of hand crafted macros. This way it is not needed to > > re-compile the kernel to enable bsg debug outputs and it's possible to > > selectively enable specific prints. > > Perhaps better to use > > #define bsg_dbg(bd, fmt, ...) \ > pr_debug(bd->name, fmt, ##__VA_ARGS__) Hello Joe, Why do you think that would be better? Thanks, Bart.