Re: [PATCH TRIVIAL] bsg: use pr_debug instead of hand crafted macros

Bart Van Assche
2018-01-22T16:33:40Z

On 01/21/18 23:53, Johannes Thumshirn wrote:
> - dprintk("map hdr %llx/%u %llx/%u\n", (unsigned long long) hdr->dout_xferp,
> + pr_debug("map hdr %llx/%u %llx/%u\n",
> + (unsigned long long) hdr->dout_xferp,
> hdr->dout_xfer_len, (unsigned long long) hdr->din_xferp,
> hdr->din_xfer_len);

Should the indentation of the arguments have been adjusted?

> @@ -299,7 +292,7 @@ static void bsg_rq_end_io(struct request *rq, blk_status_t status)
> struct bsg_device *bd = bc->bd;
> unsigned long flags;
>
> - dprintk("%s: finished rq %p bc %p, bio %p\n",
> + pr_debug("%s: finished rq %p bc %p, bio %p\n",
> bd->name, rq, bc, bc->bio);

Same question here ...

Thanks,

Bart.