From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932153AbeAXHLn (ORCPT ); Wed, 24 Jan 2018 02:11:43 -0500 Received: from mga05.intel.com ([192.55.52.43]:29967 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752355AbeAXHLl (ORCPT ); Wed, 24 Jan 2018 02:11:41 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,405,1511856000"; d="scan'208";a="12190446" Message-ID: <1516777898.7000.1210.camel@linux.intel.com> Subject: Re: [PATCH v1 1/4] seq_file: Introduce DEFINE_SHOW_ATTRIBUTE() helper macro From: Andy Shevchenko To: Darren Hart , Lee Jones Cc: platform-driver-x86@vger.kernel.org, Linus Walleij , Marcel Holtmann , linux-kernel@vger.kernel.org Date: Wed, 24 Jan 2018 09:11:38 +0200 In-Reply-To: <20180124000529.GH16464@fury> References: <20180122160546.51611-1-andriy.shevchenko@linux.intel.com> <20180123091508.6vpygg6ahrnynpks@dell> <20180124000529.GH16464@fury> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-01-23 at 16:05 -0800, Darren Hart wrote: > On Tue, Jan 23, 2018 at 09:15:08AM +0000, Lee Jones wrote: > > On Mon, 22 Jan 2018, Andy Shevchenko wrote: > > > > > The DEFINE_SHOW_ATTRIBUTE() helper macro would be useful for > > > current > > > users, which are many of them, and for new comers to decrease code > > > duplication. > > > > > > Signed-off-by: Andy Shevchenko > > > --- > > > drivers/mfd/ab8500-debugfs.c | 14 -------------- > > > > Acked-by: Lee Jones > > Thanks Andy, > > Acked-by: Darren Hart (VMware) Just to clarify a bit. Since the patch series is based on linux-next, the idea is to push it and send as second PR to Linus, after others will be ready in mainline. The rationale is to allow many other current users and perhaps new comers, e.g. [1], to utilize it already in the next cycle. [1]: https://patchwork.kernel.org/patch/10172393/ -- Andy Shevchenko Intel Finland Oy