public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Andi Kleen <ak@linux.intel.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Kosina <jikos@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Rusty Russell <rusty@rustcorp.com.au>,
	"Van De Ven, Arjan" <arjan.van.de.ven@intel.com>,
	Jessica Yu <jeyu@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "module: Add retpoline tag to VERMAGIC"
Date: Wed, 24 Jan 2018 19:31:22 +0000	[thread overview]
Message-ID: <1516822282.13558.176.camel@infradead.org> (raw)
In-Reply-To: <20180124181735.GB26209@tassilo.jf.intel.com>

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

On Wed, 2018-01-24 at 10:17 -0800, Andi Kleen wrote:
> +/* A module has been loaded. Disable reporting that we're good. */
> +void disable_retpoline(void)
> +{
> +       spectre_v2_enabled = SPECTRE_V2_NONE;

That wants to be one of the 'MINIMAL' variants.

> +       pr_err("system may be vunerable to spectre\n");
> +}
> +
> +bool retpoline_enabled(void)
> +{
> +       return spectre_v2_enabled != SPECTRE_V2_NONE;

How about checking for X86_FEATURE_RETPOLINE?

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]

  parent reply	other threads:[~2018-01-24 19:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24 14:28 [PATCH] Revert "module: Add retpoline tag to VERMAGIC" Greg Kroah-Hartman
2018-01-24 15:44 ` Andi Kleen
2018-01-24 17:00 ` Linus Torvalds
2018-01-24 18:17   ` Andi Kleen
2018-01-24 19:21     ` Randy Dunlap
2018-01-24 19:31     ` David Woodhouse [this message]
2018-01-25  8:43     ` Thomas Gleixner
2018-01-26  0:20     ` Jessica Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516822282.13558.176.camel@infradead.org \
    --to=dwmw2@infradead.org \
    --cc=ak@linux.intel.com \
    --cc=arjan.van.de.ven@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeyu@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox