From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932987AbeAYCl5 (ORCPT ); Wed, 24 Jan 2018 21:41:57 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:39122 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932637AbeAYClz (ORCPT ); Wed, 24 Jan 2018 21:41:55 -0500 X-Google-Smtp-Source: AH8x227W5gO2V/Lxzu5BjjK6N8mUkiL0YFyZo+cFXvb/g1bY+iq2tLRWeW8u0Lbs9YYeC/cE4Qc9rA== From: Jia-Ju Bai To: axboe@kernel.dk Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] block: blk-mq-sched: Replace GFP_ATOMIC with GFP_KERNEL in blk_mq_sched_assign_ioc Date: Thu, 25 Jan 2018 10:46:26 +0800 Message-Id: <1516848386-5720-1-git-send-email-baijiaju1990@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function ioc_create_icq here is not called in atomic context. Thus GFP_ATOMIC is not necessary, and it can be replaced with GFP_KERNEL. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai --- block/blk-mq-sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c index c117bd8..d461e31 100644 --- a/block/blk-mq-sched.c +++ b/block/blk-mq-sched.c @@ -42,7 +42,7 @@ void blk_mq_sched_assign_ioc(struct request *rq, struct bio *bio) spin_unlock_irq(q->queue_lock); if (!icq) { - icq = ioc_create_icq(ioc, q, GFP_ATOMIC); + icq = ioc_create_icq(ioc, q, GFP_KERNEL); if (!icq) return; } -- 1.7.9.5