From: Mike Galbraith <efault@gmx.de>
To: Lai Jiangshan <jiangshanlai@gmail.com>, Wen Yang <wen.yang99@zte.com.cn>
Cc: Tejun Heo <tj@kernel.org>,
zhong.weidong@zte.com.cn, Jiang Biao <jiang.biao2@zte.com.cn>,
Tan Hu <tan.hu@zte.com.cn>,
kernel test robot <xiaolong.ye@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH V5 5/5] workqueue: introduce a way to set workqueue's scheduler
Date: Mon, 29 Jan 2018 05:41:20 +0100 [thread overview]
Message-ID: <1517200880.10151.15.camel@gmx.de> (raw)
In-Reply-To: <CAJhGHyACFahA2k0cX+=SngjfOV_uvCrTBbkWpGsRX4X5CGeZxQ@mail.gmail.com>
On Mon, 2018-01-29 at 12:15 +0800, Lai Jiangshan wrote:
> I think adding priority boost to workqueue(flush_work()) is the best
> way to fix the problem.
I disagree, priority boosting is needlessly invasive, takes control out
of user hands. The kernel wanting to run a workqueue does not justify
perturbing the user's critical task.
I think "give userspace rope" is always the best option, how rope is
used is none of our business. Giving the user a means to draw a simple
line in the sand, above which they run only critical stuff, below
which, they can do whatever they want, sane in our opinions or not,
lets users do whatever craziness they want/need to do, and puts the
responsibility for consequences squarely on the right set of shoulders.
-Mike
next prev parent reply other threads:[~2018-01-29 4:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 5:15 [RFC PATCH V5 1/5] workqueue: rename system workqueues Wen Yang
2018-01-27 5:15 ` [RFC PATCH V5 2/5] workqueue: expose attrs for " Wen Yang
2018-01-27 5:15 ` [RFC PATCH V5 3/5] workqueue: rename unbound_attrs to attrs Wen Yang
2018-01-27 5:15 ` [RFC PATCH V5 4/5] workqueue: convert ->nice to ->sched_attr Wen Yang
2018-01-27 5:15 ` [RFC PATCH V5 5/5] workqueue: introduce a way to set workqueue's scheduler Wen Yang
2018-01-27 9:31 ` Mike Galbraith
2018-01-27 12:37 ` Mike Galbraith
2018-01-29 4:15 ` Lai Jiangshan
2018-01-29 4:41 ` Mike Galbraith [this message]
2018-01-29 6:33 ` Lai Jiangshan
2018-01-29 7:27 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517200880.10151.15.camel@gmx.de \
--to=efault@gmx.de \
--cc=jiang.biao2@zte.com.cn \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tan.hu@zte.com.cn \
--cc=tj@kernel.org \
--cc=wen.yang99@zte.com.cn \
--cc=xiaolong.ye@intel.com \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox