From: Marco Martin <notmart@gmail.com>
To: platform-driver-x86@vger.kernel.org
Cc: mario_limonciello@dell.com, andy@infradead.org,
pali.rohar@gmail.com, dvhart@infradead.org, mjg59@srcf.ucam.org,
linux-kernel@vger.kernel.org, bhush94@gmail.com,
notmart@gmail.com, "Stefan Brüns" <stefan.bruens@rwth-aachen.de>
Subject: [PATCH] Support intel-vbtn based tablet mode switch
Date: Mon, 29 Jan 2018 21:27:43 +0100 [thread overview]
Message-ID: <1517257663-2171-1-git-send-email-notmart@gmail.com> (raw)
On some laptop like the Dell Inspiron 7000 series
tablet mode switch implemented in Intel ACPI,
the events to enter and exit the tablet mode are 0xCC and 0xCD
This initializes the tablet/laptop mode at the correct value
if the system booted in tablet mode (or the vbtn module loaded
with the device in tablet mode)
CC: platform-driver-x86@vger.kernel.org
CC: Matthew Garrett <mjg59@srcf.ucam.org>
CC: "Pali Rohár" <pali.rohar@gmail.com>
CC: Darren Hart <dvhart@infradead.org>
CC: Mario Limonciello <mario_limonciello@dell.com>
CC: Andy Shevchenko <andy@infradead.org>
CC: Stefan Brüns<stefan.bruens@rwth-aachen.de>
Signed-off-by: Marco Martin <notmart@gmail.com>
Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
Acked-by: Pali Rohár <pali.rohar@gmail.com>
---
drivers/platform/x86/intel-vbtn.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
index 5fc4315..019ff21 100644
--- a/drivers/platform/x86/intel-vbtn.c
+++ b/drivers/platform/x86/intel-vbtn.c
@@ -26,6 +26,9 @@
#include <linux/suspend.h>
#include <acpi/acpi_bus.h>
+/* When NOT in tablet mode, VGBS returns with the flag 0x40 */
+#define TABLET_MODE_FLAG 0x40
+
MODULE_LICENSE("GPL");
MODULE_AUTHOR("AceLan Kao");
@@ -108,6 +111,7 @@ static void notify_handler(acpi_handle handle, u32 event, void *context)
static int intel_vbtn_probe(struct platform_device *device)
{
+ struct acpi_buffer vgbs_output = { ACPI_ALLOCATE_BUFFER, NULL };
acpi_handle handle = ACPI_HANDLE(&device->dev);
struct intel_vbtn_priv *priv;
acpi_status status;
@@ -130,6 +134,22 @@ static int intel_vbtn_probe(struct platform_device *device)
return err;
}
+ status = acpi_evaluate_object(handle, "VGBS", NULL, &vgbs_output);
+ /* VGBS being present and returning something means
+ * we have a tablet mode switch
+ */
+ if (ACPI_SUCCESS(status)) {
+ union acpi_object *obj = vgbs_output.pointer;
+
+ if (obj && obj->type == ACPI_TYPE_INTEGER) {
+ input_report_switch(priv->input_dev,
+ SW_TABLET_MODE,
+ !(obj->integer.value & TABLET_MODE_FLAG));
+ }
+ }
+
+ kfree(vgbs_output.pointer);
+
status = acpi_install_notify_handler(handle,
ACPI_DEVICE_NOTIFY,
notify_handler,
--
2.7.4
next reply other threads:[~2018-01-29 20:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 20:27 Marco Martin [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-23 15:17 [PATCH] Support intel-vbtn based tablet mode switch Marco Martin
2018-01-22 12:48 Marco Martin
2018-01-22 13:42 ` Andy Shevchenko
2018-01-22 13:52 ` Marco Martin
2018-01-22 14:46 ` Andy Shevchenko
2018-01-22 23:46 ` Dmitry Torokhov
2018-01-23 12:42 ` Marco Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517257663-2171-1-git-send-email-notmart@gmail.com \
--to=notmart@gmail.com \
--cc=andy@infradead.org \
--cc=bhush94@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario_limonciello@dell.com \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stefan.bruens@rwth-aachen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox