From: "Brown, Nicholas" <nb930b@intl.att.com>
To: "joe@perches.com" <joe@perches.com>,
"apw@canonical.com" <apw@canonical.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] checkpatch: warn if changed lines exceeds a maximum size
Date: Tue, 30 Jan 2018 15:04:59 +0000 [thread overview]
Message-ID: <1517324698.3063.16.camel@intl.att.com> (raw)
Changed lines is the total of inserted and deleted lines.
By default there is no limit, --max-changed-lines may be used to set a
value. Some users may wish to encourage that patches are split into
smaller parts using this.
See Documentation/process/submitting-patches.rst#split-changes
Signed-off-by: Nicholas Brown <nick.brown@att.com>
---
scripts/checkpatch.pl | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 31031f10fe56..1217d782b6bb 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -49,6 +49,7 @@ my @ignore = ();
my $help = 0;
my $configuration_file = ".checkpatch.conf";
my $max_line_length = 80;
+my $max_changed_lines; # undef = no max
my $ignore_perl_version = 0;
my $minimum_perl_version = 5.10.0;
my $min_conf_desc_length = 4;
@@ -209,6 +210,7 @@ GetOptions(
'show-types!' => \$show_types,
'list-types!' => \$list_types,
'max-line-length=i' => \$max_line_length,
+ 'max-changed-lines=i' => \$max_changed_lines,
'min-conf-desc-length=i' => \$min_conf_desc_length,
'root=s' => \$root,
'summary!' => \$summary,
@@ -2165,6 +2167,8 @@ sub process {
my $filename = shift;
my $linenr=0;
+ my $inserted_lines_total=0;
+ my $deleted_lines_total=0;
my $prevline="";
my $prevrawline="";
my $stashline="";
@@ -2233,6 +2237,14 @@ sub process {
push(@fixed, $rawline) if ($fix);
+ if ($rawline=~/^\+/) {
+ $inserted_lines_total++
+ }
+
+ if ($rawline=~/^-/) {
+ $deleted_lines_total++
+ }
+
if ($rawline=~/^\+\+\+\s+(\S+)/) {
$setup_docs = 0;
if ($1 =~ m@Documentation/admin-guide/kernel-parameters.rst$@) {
@@ -2306,6 +2318,11 @@ sub process {
$prefix = '';
+ if (defined $max_changed_lines &&
+ ($inserted_lines_total+$deleted_lines_total > $max_changed_lines)) {
+ WARN("MAX_CHANGED_LINES", "please split the change into smaller parts\n");
+ }
+
$realcnt = 0;
$linenr = 0;
$fixlinenr = -1;
--
2.14.1
next reply other threads:[~2018-01-30 17:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 15:04 Brown, Nicholas [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-30 15:57 [PATCH] checkpatch: warn if changed lines exceeds a maximum size Brown, Nicholas
2018-01-30 16:10 ` Joe Perches
2018-01-30 18:04 ` Brown, Nicholas
2018-01-30 19:01 ` Nicholas Brown
2018-01-30 19:09 ` Joe Perches
2018-01-30 20:25 ` Brown, Nicholas
2018-01-30 20:26 ` Nicholas Brown
[not found] ` <1517481518.3063.92.camel@intl.att.com>
2018-02-01 12:54 ` Joe Perches
2018-02-01 15:42 ` Brown, Nicholas
2018-02-01 16:03 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517324698.3063.16.camel@intl.att.com \
--to=nb930b@intl.att.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox