From: David Woodhouse <dwmw2@infradead.org>
To: "Radim Krčmář" <rkrcmar@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
KarimAllah Ahmed <karahmed@amazon.de>
Subject: Re: [PATCH v2 3/3] KVM: VMX: make MSR bitmaps per-VCPU
Date: Tue, 30 Jan 2018 16:30:02 +0000 [thread overview]
Message-ID: <1517329802.18619.128.camel@infradead.org> (raw)
In-Reply-To: <20180130162357.GE22015@flask>
[-- Attachment #1: Type: text/plain, Size: 798 bytes --]
On Tue, 2018-01-30 at 17:23 +0100, Radim Krčmář wrote:
>
> The physical address of the nested msr_bitmap is never loaded into vmcs.
>
> The resolution you provided had extra hunk in prepare_vmcs02_full():
>
> + vmcs_write64(MSR_BITMAP, __pa(vmx->nested.vmcs02.msr_bitmap));
>
> I have queued that as:
>
> + if (cpu_has_vmx_msr_bitmap())
> + vmcs_write64(MSR_BITMAP, __pa(vmx->nested.vmcs02.msr_bitmap));
>
> but it should be a part of the patch or a followup fix.
>
> Is the branch already merged into PTI?
No, we've never seen a 4.14-based branch that could be merged. I made
one myself for the moment but assumed there would be one from Paulo
that was then pulled into both tip/x86/pti and the kvm.git tree.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]
next prev parent reply other threads:[~2018-01-30 16:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 8:50 [PATCH v2 0/3] Per-VCPU MSR bitmaps patches - topic branch for x86/pti Paolo Bonzini
2018-01-27 8:50 ` [PATCH v2 1/3] KVM: nVMX: Eliminate vmcs02 pool Paolo Bonzini
2018-01-27 8:50 ` [PATCH v2 2/3] KVM: VMX: introduce alloc_loaded_vmcs Paolo Bonzini
2018-01-29 10:31 ` David Hildenbrand
2018-01-27 8:50 ` [PATCH v2 3/3] KVM: VMX: make MSR bitmaps per-VCPU Paolo Bonzini
2018-01-29 10:35 ` David Hildenbrand
2018-01-30 13:07 ` [v2,3/3] " Mihai Carabas
2018-01-30 16:23 ` [PATCH v2 3/3] " Radim Krčmář
2018-01-30 16:30 ` David Woodhouse [this message]
2018-01-31 17:37 ` Paolo Bonzini
2018-01-31 18:14 ` Radim Krčmář
2018-01-29 12:53 ` [PATCH v2 0/3] Per-VCPU MSR bitmaps patches - topic branch for x86/pti David Woodhouse
2018-01-29 14:28 ` Paolo Bonzini
2018-01-29 14:57 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517329802.18619.128.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=karahmed@amazon.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).