public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: Joe Smith <codesoldier1@gmail.com>
Cc: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: crash binary for latest unreleased kernel
Date: Wed, 31 Jan 2018 17:03:53 +0100	[thread overview]
Message-ID: <1517414633.10864.6.camel@gmx.de> (raw)
In-Reply-To: <1517370670.7130.2.camel@gmx.de>

On Wed, 2018-01-31 at 04:51 +0100, Mike Galbraith wrote:
> On Sun, 2018-01-28 at 12:19 -0800, Joe Smith wrote:
> > Thanks a lot, Mike. Following your suggestions worked !!!!
> 
> Until Monday happened :)

And during a rare non-lazy-sod moment...

---
 task.c |   15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

--- a/task.c
+++ b/task.c
@@ -438,8 +438,21 @@ task_init(void)
 			len = SIZE(task_union));
 		machdep->stacksize = len;
 	} else if (VALID_SIZE(thread_union) && 
-	    	((len = SIZE(thread_union)) != STACKSIZE())) 
+		   ((len = SIZE(thread_union)) != STACKSIZE())) {
 		machdep->stacksize = len;
+	} else {
+		/*
+		 * Post kernel commit 0500871f21b2, init_thread_union size
+		 * became zero.  Use __end_init_task - __start_init_task.
+		 */
+		if (kernel_symbol_exists("__start_init_task") &&
+		    kernel_symbol_exists("__end_init_task")) {
+			len = symbol_value("__end_init_task");
+			len -= symbol_value("__start_init_task");
+			ASSIGN_SIZE(thread_union) = len;
+			machdep->stacksize = len;
+		}
+	}
 
 	MEMBER_OFFSET_INIT(pid_namespace_idr, "pid_namespace", "idr");
 	MEMBER_OFFSET_INIT(idr_idr_rt, "idr", "idr_rt");

      reply	other threads:[~2018-01-31 16:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-26 20:52 crash binary for latest unreleased kernel Joe Smith
2018-01-27  4:32 ` Mike Galbraith
2018-01-27  4:38   ` Randy Dunlap
2018-01-27  4:48     ` Mike Galbraith
2018-01-28  8:37       ` Joe Smith
2018-01-28  9:20         ` Mike Galbraith
2018-01-28 10:00           ` Mike Galbraith
2018-01-28 20:19             ` Joe Smith
2018-01-31  3:51               ` Mike Galbraith
2018-01-31 16:03                 ` Mike Galbraith [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517414633.10864.6.camel@gmx.de \
    --to=efault@gmx.de \
    --cc=codesoldier1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox