From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Darren Hart <dvhart@infradead.org>
Cc: platform-driver-x86@vger.kernel.org,
AceLan Kao <acelan.kao@canonical.com>,
linux-kernel@vger.kernel.org, pali.rohar@gmail.com,
Mario Limonciello <mario.limonciello@dell.com>,
Rafael Wysocki <rjw@rjwysocki.net>
Subject: Re: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver
Date: Mon, 05 Feb 2018 18:18:11 +0200 [thread overview]
Message-ID: <1517847491.22495.36.camel@linux.intel.com> (raw)
In-Reply-To: <20180131213726.GB21498@fury>
On Wed, 2018-01-31 at 13:37 -0800, Darren Hart wrote:
> On Wed, Jan 31, 2018 at 08:26:14PM +0200, Andy Shevchenko wrote:
> > Remove code duplication by converting driver to pure ACPI one.
>
I have fixed couple issues, but...
> +Rafael
>
> I don't see any reason *not* to do this, it seems the acpi driver
> model provides
> some of the boilerplate stuff we were doing manually before as a
> platform
> device. I'm scratching my head wondering why we did this as a
> platform-driver in
> the first place now...
...I still keep in my review queue in a hope that someone can actually
test this on real hardware.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-02-05 16:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 18:26 [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver Andy Shevchenko
2018-01-31 21:37 ` Darren Hart
2018-02-05 16:18 ` Andy Shevchenko [this message]
2018-02-06 20:33 ` Mario.Limonciello
[not found] ` <CAHp75VeFSuQYu67DdnJDjZDoaLZiPuo7ag7Lz0q6eSCDjayobw@mail.gmail.com>
2018-02-07 1:57 ` Mario.Limonciello
2018-02-07 9:31 ` Rafael J. Wysocki
2018-02-07 9:47 ` Rafael J. Wysocki
2018-02-07 9:55 ` Pali Rohár
2018-02-07 13:08 ` Mario.Limonciello
2018-02-07 13:18 ` Andy Shevchenko
2018-02-07 22:50 ` Rafael J. Wysocki
2018-02-07 22:33 ` Rafael J. Wysocki
2018-02-07 9:44 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517847491.22495.36.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=acelan.kao@canonical.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox