linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: KarimAllah Ahmed <karahmed@amazon.de>
To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: "KarimAllah Ahmed" <karahmed@amazon.de>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>
Subject: [RFC 08/12] KVM/VMX: Use the new host mapping API for mapping nested PML
Date: Mon,  5 Feb 2018 19:47:27 +0100	[thread overview]
Message-ID: <1517856451-2932-9-git-send-email-karahmed@amazon.de> (raw)
In-Reply-To: <1517856451-2932-1-git-send-email-karahmed@amazon.de>

For nested guests the PML page was mapped to the host kernel using
kvm_vcpu_gpa_to_page which assumes that all guest memory is backed by a
"struct page". This breaks guests that have their memory outside the kernel
control.

Switch to the new host mapping API which takes care of this use-case as
well.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Radim Krčmář <rkrcmar@redhat.com>
Cc: kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: KarimAllah Ahmed <karahmed@amazon.de>
---
 arch/x86/kvm/vmx.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 7177176..620b4ff 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -11866,7 +11866,7 @@ static int vmx_write_pml_buffer(struct kvm_vcpu *vcpu)
 	struct vmcs12 *vmcs12;
 	struct vcpu_vmx *vmx = to_vmx(vcpu);
 	gpa_t gpa;
-	struct page *page = NULL;
+	struct kvm_host_mapping mapping;
 	u64 *pml_address;
 
 	if (is_guest_mode(vcpu)) {
@@ -11888,14 +11888,13 @@ static int vmx_write_pml_buffer(struct kvm_vcpu *vcpu)
 
 		gpa = vmcs_read64(GUEST_PHYSICAL_ADDRESS) & ~0xFFFull;
 
-		page = kvm_vcpu_gpa_to_page(vcpu, vmcs12->pml_address);
-		if (is_error_page(page))
+		if (!kvm_vcpu_gpa_to_host_mapping(vcpu, vmcs12->pml_address, &mapping, true))
 			return 0;
 
-		pml_address = kmap(page);
+		pml_address = mapping.kaddr;
 		pml_address[vmcs12->guest_pml_index--] = gpa;
-		kunmap(page);
-		kvm_release_page_clean(page);
+
+		kvm_release_host_mapping(&mapping, false);
 	}
 
 	return 0;
-- 
2.7.4

  parent reply	other threads:[~2018-02-05 18:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05 18:47 [RFC 00/12] KVM/X86: Introduce a new guest mapping API KarimAllah Ahmed
2018-02-05 18:47 ` [RFC 01/12] KVM: Introduce helper functions to map/unmap guest memory KarimAllah Ahmed
2018-02-05 18:47 ` [RFC 02/12] KVM/VMX: Use the new host mapping API for apic_access_page KarimAllah Ahmed
2018-02-05 19:27   ` Jim Mattson
2018-02-05 18:47 ` [RFC 03/12] KVM/VMX: Use the new host mapping API for virtual_apic_page KarimAllah Ahmed
2018-02-05 22:26   ` Jim Mattson
2018-02-09 12:15     ` KarimAllah Ahmed
2018-02-09 22:55       ` Jim Mattson
2018-02-05 18:47 ` [RFC 04/12] KVM/VMX: Use the new host mapping API for pi_desc_page KarimAllah Ahmed
2018-02-05 18:47 ` [RFC 05/12] KVM/VMX: Use the new host mapping API for mapping nested vmptr KarimAllah Ahmed
2018-02-05 22:15   ` Jim Mattson
2018-02-08 18:51     ` KarimAllah Ahmed
2018-02-05 18:47 ` [RFC 06/12] KVM/VMX: Use the new host mapping API for handle_vmptrld KarimAllah Ahmed
2018-02-05 18:47 ` [RFC 07/12] KVM/VMX: Use the new host mapping API for mapping L12 MSR bitmap KarimAllah Ahmed
2018-02-05 18:47 ` KarimAllah Ahmed [this message]
2018-02-05 18:47 ` [RFC 09/12] KVM/VMX: Use the new host mapping API for cmpxchg_emulated KarimAllah Ahmed
2018-02-05 18:47 ` [RFC 10/12] KVM/VMX: Use the new host mapping API for synic_clear_sint_msg_pending KarimAllah Ahmed
2018-02-05 18:47 ` [RFC 11/12] KVM/VMX: Use the new host mapping API for synic_deliver_msg KarimAllah Ahmed
2018-02-05 18:47 ` [RFC 12/12] KVM/VMX: Remove kvm_vcpu_gpa_to_page as it is now unused KarimAllah Ahmed
2018-02-05 19:26 ` [RFC 00/12] KVM/X86: Introduce a new guest mapping API Mihai Donțu
2018-02-10 11:33   ` KarimAllah Ahmed
2018-02-16 11:40     ` Mihai Donțu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517856451-2932-9-git-send-email-karahmed@amazon.de \
    --to=karahmed@amazon.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).