From: Nitesh Shetty <nj.shetty@samsung>
To: unlisted-recipients:; (no To-header on input)
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, joshi.k@samsung.com,
Nitesh Shetty <nj.shetty@samsung.com>
Subject: [PATCH v2] blk: optimization for classic polling
Date: Fri, 9 Feb 2018 16:12:16 -0500 [thread overview]
Message-ID: <1518210736-2255-1-git-send-email-user@ubuntu> (raw)
In-Reply-To: <Re: [PATCH] blk: optimization for classic polling>
From: Nitesh Shetty <nj.shetty@samsung.com>
This removes the dependency on interrupts to wake up task. Set task
state as TASK_RUNNING, if need_resched() returns true,
while polling for IO completion.
Earlier, polling task used to sleep, relying on interrupt to wake it up.
This made some IO take very long when interrupt-coalescing is enabled in
NVMe.
Changes v1->v2:
-setting task state once in blk_poll, instead of multiple callers.
Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com>
---
block/blk-mq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index df93102..40285fe 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -3164,6 +3164,7 @@ static bool __blk_mq_poll(struct blk_mq_hw_ctx *hctx, struct request *rq)
cpu_relax();
}
+ set_current_state(TASK_RUNNING);
return false;
}
--
2.7.4
parent reply other threads:[~2018-02-09 10:42 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <Re: [PATCH] blk: optimization for classic polling>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518210736-2255-1-git-send-email-user@ubuntu \
--to=nj.shetty@samsung \
--cc=axboe@kernel.dk \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nj.shetty@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox