From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933603AbeBLKIb (ORCPT ); Mon, 12 Feb 2018 05:08:31 -0500 Received: from mga18.intel.com ([134.134.136.126]:33152 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933579AbeBLKI2 (ORCPT ); Mon, 12 Feb 2018 05:08:28 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,501,1511856000"; d="scan'208";a="29328242" Message-ID: <1518430103.22495.252.camel@linux.intel.com> Subject: Re: [PATCH] gpio: merrifield: Delete an error message for a failed memory allocation in mrfld_gpio_probe() From: Andy Shevchenko To: SF Markus Elfring , linux-gpio@vger.kernel.org, Linus Walleij Cc: LKML , kernel-janitors@vger.kernel.org Date: Mon, 12 Feb 2018 12:08:23 +0200 In-Reply-To: References: Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2018-02-11 at 13:42 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 11 Feb 2018 13:30:14 +0100 > > Omit an extra message for a memory allocation failure in this > function. > > This issue was detected by using the Coccinelle software. > Linus, I have no strong opinion here, so, up to you to decide. If you decide this patch to go, Acked-by: Andy Shevchenko > Signed-off-by: Markus Elfring > --- > drivers/gpio/gpio-merrifield.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpio/gpio-merrifield.c b/drivers/gpio/gpio- > merrifield.c > index dd67a31ac337..eec21122299e 100644 > --- a/drivers/gpio/gpio-merrifield.c > +++ b/drivers/gpio/gpio-merrifield.c > @@ -408,10 +408,8 @@ static int mrfld_gpio_probe(struct pci_dev *pdev, > const struct pci_device_id *id > pcim_iounmap_regions(pdev, BIT(1)); > > priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > - if (!priv) { > - dev_err(&pdev->dev, "can't allocate chip data\n"); > + if (!priv) > return -ENOMEM; > - } > > priv->dev = &pdev->dev; > priv->reg_base = pcim_iomap_table(pdev)[0]; -- Andy Shevchenko Intel Finland Oy